Rename Reflection section to Review; mark dedup_runs and quicksort as bonus

Rename the per-chapter 'Reflection' section (callout, slides, issue template, style/plan docs) to 'Review', tying it to the book's code-review framing.

Also flag exercises 11 (dedup_runs) and 22 (quicksort) as optional bonus exercises across the book sidebar, chapter callouts, roadmap, and slides.

Author: mre

.github/ISSUE_TEMPLATE/reflection.yml .github/ISSUE_TEMPLATE/review.yml.github/ISSUE_TEMPLATE/reflection.yml renamed to .github/ISSUE_TEMPLATE/review.yml

@@ -1,7 +1,7 @@
-name: Suggest a Reflection question
+name: Suggest a Review question
 description: A question a thoughtful reviewer would ask on a chapter that we missed.
-title: "[reflection] ch. NN: <one-line summary>"
-labels: ["reflection", "book"]
+title: "[review] ch. NN: <one-line summary>"
+labels: ["review", "book"]
 body:
   - type: input
     id: chapter
@@ -14,7 +14,7 @@ body:
     id: question
     attributes:
       label: Your suggested question
-      description: Write it as you would in the Reflection callout.
+      description: Write it as you would in the Review callout.
     validations:
       required: true
   - type: textarea

CONTRIBUTING.md

@@ -53,7 +53,7 @@ use the issue templates at
 `.github/ISSUE_TEMPLATE/` — they correspond to the kinds of feedback
 that genuinely help:
 
-- **Suggest a Reflection question** — a question a thoughtful reviewer
+- **Suggest a Review question** — a question a thoughtful reviewer
   would ask on a chapter that we missed.
 - **Suggest a Trade-off** — an axis or consideration we didn't score.
 - **Suggest an Edge case** — production concerns that aren't covered.

TODO.md

@@ -5,13 +5,13 @@
 
 ---
 
-## 1. Put reflection prompts next to the source code (on a dedicated slide)
+## 1. Put review prompts next to the source code (on a dedicated slide)
 
 Each exercise should be a 3-slide sequence:
 
 1. **Source code only** — the starter, full width.
-2. **Source code + reflection prompts side-by-side** — same starter on
-   the left, reflection bullets on the right.
+2. **Source code + review prompts side-by-side** — same starter on
+   the left, review bullets on the right.
 3. **Possible solution** — as today.
 
 Use Slidev's `two-cols-header` layout for step 2:
@@ -36,11 +36,11 @@ pub fn describe(...) { ... }
 ```
 
 Notes:
-- Reflection bullets and the hint already render all-at-once (no
+- Review bullets and the hint already render all-at-once (no
   `v-clicks` animations).
 - Decide whether this applies to **every** exercise or only the ones
   where the starter is short enough to leave room on the right.
-- The current standalone `# NN · Reflection` slide goes away once
+- The current standalone `# NN · Review` slide goes away once
   the side-by-side version exists.
 
 ---

book/PLAN.md

@@ -65,7 +65,7 @@ sections** included only when there's something real to say.
    in real code.
 2. **Starter code**: `{{#include}}` from `examples/NN_*.rs`. Includes an
    inline "Try it yourself" callout with the `cargo` invocations.
-3. **Reflection**: the questions a thoughtful reviewer would ask, framed
+3. **Review**: the questions a thoughtful reviewer would ask, framed
    as prompts to the *reader*. (Renamed from "Observations", also update
    the slides under TODO item #1 in `TODO.md`.)
 4. **A possible solution**: the canonical solution from `solutions/`,
@@ -173,15 +173,15 @@ The book is physically incapable of shipping broken code.
 
 **Senior-engineer-reviewing-with-you voice** (first-person plural for
 narration, first-person singular for contested opinions), with **light
-direct address** in Reflection and Follow-up sections.
+direct address** in Review and Follow-up sections.
 
 Style rules (full version goes in `book/STYLE.md`):
 
 - Default to **we** for narration ("we'd reach for `&str` here because…").
 - Use **I** sparingly, only for genuinely contested opinions
   ("I'll admit I find `is_some_and` slightly noisier than
   `map_or(false, …)`, but…").
-- Use **you** only in Reflection prompts, Follow-up questions, and explicit
+- Use **you** only in Review prompts, Follow-up questions, and explicit
   instructions ("Try replacing the `Vec` with an iterator and see what
   breaks").
 - Never **the reader** / **one** / passive-voice avoidance of pronouns.
@@ -308,7 +308,7 @@ launch.
   chapters. **File an issue instead**, substantive suggestions are
   credited in Acknowledgements when adopted.
 - **Issue templates** in `.github/ISSUE_TEMPLATE/`:
-  - Suggest a Reflection question
+  - Suggest a Review question
   - Suggest a Trade-off I missed
   - Suggest an Edge case
   - Found a typo / bug
@@ -330,7 +330,7 @@ v1 scope:
 - Search on; sidebar on; prev/next on; stock playground button on `rust`
   blocks.
 - Blockquote-based callouts with a small CSS treatment to differentiate
-  the 7-section spine labels (`EXERCISE`, `REFLECTION`, `TRY THIS`,
+  the 7-section spine labels (`EXERCISE`, `REVIEW`, `TRY THIS`,
   `TRADE-OFF`, `EDGE CASE`, `FOLLOW-UP`, `CONCEPT`).
 - Light + dark only; kill the other three default themes (coal, ayu,
   rust) unless that creates friction.
@@ -408,7 +408,7 @@ written by copying their shape. No separate format spec document.
 - `STYLE.md` skeleton (extended through Phase 2).
 - `CONTRIBUTING.md` + issue templates.
 - `LICENSE` (root) + `book/LICENSE.md`.
-- Rename "Observations" → "Reflection" in `slides/pages/*.md` (TODO item
+- Rename "Observations" → "Review" in `slides/pages/*.md` (TODO item
   #1 in the existing `TODO.md`).
 
 ### Phase 1, Thesis (~3 days)

book/STYLE.md

@@ -14,7 +14,7 @@
   *"I'll admit I find `is_some_and` slightly noisier than
   `map_or(false, …)`, but the predicate reads in order of evaluation."*
 - **Use "you"** in:
-  - *Reflection* prompts
+  - *Review* prompts
   - *Follow-up questions*
   - explicit instructions ("Try replacing the `Vec` with an iterator
     and see what breaks")
@@ -70,7 +70,7 @@ Every chapter follows the 7-section spine from `PLAN.md` §3:
 
 1. The problem
 2. Starter code
-3. Reflection
+3. Review
 4. A possible solution
 5. Trade-offs (six fixed axes; same order every time)
 6. Quiz
@@ -90,7 +90,7 @@ The CSS in `theme/css/corrode.css` styles the leading `**LABEL**` as a
 small-caps badge.
 
 ```markdown
-> **REFLECTION**
+> **REVIEW**
 >
 > - Does the function need to own the string?
 > - What does `chars().nth(0)` do, and is there a more direct way?
@@ -99,7 +99,7 @@ small-caps badge.
 Standard labels:
 
 - `EXERCISE`: wraps the starter listing
-- `REFLECTION`: the questions a thoughtful reviewer would ask
+- `REVIEW`: the questions a thoughtful reviewer would ask
 - `TRY THIS`: an inline call to action
 - `TRADE-OFF`: the per-chapter scoring section
 - `EDGE CASE`: production concerns

book/src/SUMMARY.md

@@ -29,7 +29,7 @@
 # Part III. Aggregations & counting
 
 - [Overview](part-3-aggregations/README.md)
-  - [11 · dedup_runs](part-3-aggregations/11-dedup-runs.md)
+  - [11 · dedup_runs (bonus)](part-3-aggregations/11-dedup-runs.md)
   - [12 · excluded_path](part-3-aggregations/12-excluded-path.md)
   - [13 · spell_check](part-3-aggregations/13-spell-check.md)
   - [14 · room_occupancy](part-3-aggregations/14-room-occupancy.md)
@@ -44,7 +44,7 @@
   - [19 · iterators](part-4-strings-parsing/19-iterators.md)
   - [20 · transformer](part-4-strings-parsing/20-transformer.md)
   - [21 · fun_strings_ext](part-4-strings-parsing/21-fun-strings-ext.md)
-  - [22 · quicksort](part-4-strings-parsing/22-quicksort.md)
+  - [22 · quicksort (bonus)](part-4-strings-parsing/22-quicksort.md)
 
 # Part V. Domain modeling
 

book/src/how-to-use.md

@@ -15,7 +15,7 @@ default mode. For each chapter:
 3. **Stop reading the chapter.** Make a list of what you'd say in a
    review. Try to refactor the code yourself in your editor. Spend
    five to twenty minutes, depending on the chapter's size.
-4. Then read *Reflection* and see which of your observations match
+4. Then read *Review* and see which of your observations match
    ours, and which we surfaced that you didn't.
 5. Read *A possible solution* and compare it to yours.
 6. Read *Trade-offs* and decide whether you agree with our scoring.
@@ -31,8 +31,8 @@ them. A little trick is to delete your first attempt at the refactor before tryi
 ## Pair
 
 Two engineers, one keyboard. One drives (writes the refactor), one
-reviews (asks the *Reflection* questions out loud, gently). Swap roles
-every chapter, or every other chapter. The chapter's *Reflection*
+reviews (asks the *Review* questions out loud, gently). Swap roles
+every chapter, or every other chapter. The chapter's *Review*
 section gives the reviewer their script, but the best discussions
 happen when the reviewer goes off-script.
 
@@ -45,7 +45,7 @@ A small group, three to eight people, reads one chapter per week.
 Anyone who wants to brings their refactored version. The meeting (an
 hour, max) walks through:
 
-1. What each person noticed in *Reflection* before reading ours.
+1. What each person noticed in *Review* before reading ours.
 2. Whose solution is closest to the canonical, whose is furthest, why.
 3. Where the group disagrees with the *Trade-offs* scoring.
 4. The *Follow-up questions*. These were chosen for exactly this
@@ -61,7 +61,7 @@ if your team is past them.
 If you're running an internal workshop, the slides in `slides/`
 (<https://github.com/corrode/refactoring>) are the live-delivery
 artifact and the book is your reference companion. Use the chapter's
-*Reflection* questions as your prompts to the room; use *Trade-offs*
+*Review* questions as your prompts to the room; use *Trade-offs*
 to keep the discussion honest when it veers into religion; use
 *Follow-up questions* as the breakout-room material.
 
@@ -118,7 +118,7 @@ labelled block:
 >
 > Wraps the starter listing. *"Here's what you're refactoring."*
 
-> **REFLECTION**
+> **REVIEW**
 >
 > The questions a thoughtful reviewer would ask. The book's signature
 > section.
@@ -144,6 +144,10 @@ labelled block:
 > [Cheatsheet](appendix/concept-index.md) entry where it's defined
 > properly and linked from every other chapter that touches it.
 
+A few chapters open with a **BONUS** callout. Those are optional: skip
+them if you're short on time, since nothing later in the book depends
+on them.
+
 ## Filing issues
 
 If you spot a typo, a broken link, a refactor we missed, or a

book/src/part-1-warmups/01-starts-with-uppercase.md

@@ -6,7 +6,7 @@
 >
 > 1. The problem
 > 2. Starter code (`{{#include}}` from `examples/`)
-> 3. Reflection
+> 3. Review
 > 4. A possible solution
 > 5. Trade-offs (six axes)
 > 6. Quiz (after Trade-offs, before Follow-ups)

book/src/part-1-warmups/02-better-match.md

@@ -6,7 +6,7 @@
 >
 > 1. The problem
 > 2. Starter code (`{{#include}}` from `examples/`)
-> 3. Reflection
+> 3. Review
 > 4. A possible solution
 > 5. Trade-offs (six axes)
 > 6. Quiz (after Trade-offs, before Follow-ups)

book/src/part-1-warmups/03-even-numbers.md

@@ -6,7 +6,7 @@
 >
 > 1. The problem
 > 2. Starter code (`{{#include}}` from `examples/`)
-> 3. Reflection
+> 3. Review
 > 4. A possible solution
 > 5. Trade-offs (six axes)
 > 6. Quiz (after Trade-offs, before Follow-ups)