-
Notifications
You must be signed in to change notification settings - Fork 823
Description
Is your feature request related to a problem? Please describe.
There is a TODO in distributor receiving native histogram samples.
// TODO(yeya24): add max schema validation for native histogram if needed.
We need to make sure that the Native Histogram samples' schema is valid ( >= -4 && <= 8). This is important because certain functionalities of native histogram in Prometheus require the schema to be exponential schema (>=-4 && <=8).
Note that all native histogram samples collected from Prometheus should have valid schema except NHCB today. However, exponential histogram from OTEL might have invalid schema outside the range if the collector doesn't convert the schema to be Prometheus compatible in certain versions.
Describe the solution you'd like
Add validation in Distributor and maybe Ingester to make sure the ingested Native Histogram sample has valid schema. If invalid, either reject or reduce resolution for the sample and the strategy can be configurable.
Activity