Skip to content

Commit a798dd7

Browse files
cortinicofacebook-github-bot
authored andcommitted
Enable RTTI to fix exception pointer issue on React Native (facebook#1791)
Summary: Pull Request resolved: facebook#1791 Disabling RTTI for Yoga is causing std::exception to don't work properly in OSS. Fixes: facebook/react-native#48027 Not sure why we originally disabled RTTI for Yoga, but we have it enable for the whole React Native build so it probably makes sense to have it enabled for Yoga as well. Changelog: [Internal] [Changed] - Enable RTTI to fix exception pointer issue on React Native Reviewed By: javache, NickGerleman Differential Revision: D70386744
1 parent 3aa594c commit a798dd7

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

cmake/project-defaults.cmake

+4-4
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ add_compile_options(
1919
# Enable warnings and warnings as errors
2020
/W4
2121
/WX
22-
# Disable RTTI
23-
$<$<COMPILE_LANGUAGE:CXX>:/GR->
22+
# Enable RTTI
23+
$<$<COMPILE_LANGUAGE:CXX>:/GR>
2424
# Use /O2 (Maximize Speed)
2525
$<$<CONFIG:RELEASE>:/O2>)
2626

@@ -34,8 +34,8 @@ add_compile_options(
3434
# Enable warnings and warnings as errors
3535
-Wall
3636
-Werror
37-
# Disable RTTI
38-
$<$<COMPILE_LANGUAGE:CXX>:-fno-rtti>
37+
# Enable RTTI
38+
$<$<COMPILE_LANGUAGE:CXX>:-frtti>
3939
# Use -O2 (prioritize speed)
4040
$<$<CONFIG:RELEASE>:-O2>
4141
# Enable separate sections per function/data item

0 commit comments

Comments
 (0)