add more precise tests for new functionality

Author: kossman

tests/unit/conftest.py

@@ -3,6 +3,7 @@
 
 from corva.configuration import SETTINGS
 from corva.testing import TestClient
+from corva.validate_app_init import read_manifest
 
 
 @pytest.fixture(scope='function', autouse=True)
@@ -16,6 +17,13 @@ def clean_redis():
     redis_client.flushall()
 
 
+@pytest.fixture(scope='function', autouse=True)
+def clean_read_manifest_lru_cache():
+    read_manifest.cache_clear()
+    yield
+    read_manifest.cache_clear()
+
+
 @pytest.fixture(scope='function')
 def context():
     return TestClient._context

tests/unit/test_apps_event_types.py

@@ -1,3 +1,4 @@
+import json
 from unittest import mock
 
 import pytest
@@ -15,6 +16,7 @@
     StreamTimeRecord,
 )
 from corva.models.task import RawTaskEvent
+from corva.validate_app_init import read_manifest, validate_app_type_context
 
 raw_scheduled_natural_time_event = RawScheduledNaturalTimeEvent(
     asset_id=1,
@@ -114,3 +116,44 @@ def lambda_handler(_event, _api):
                 {},
                 context,
             )
+
+
+def test__validate_app_type_with_missed_app_type_at_manifested__does_not_fails(context):
+    mocked_manifest = {"application": {"type": None}}
+
+    with mock.patch(
+        "corva.validate_app_init.read_manifest", return_value=mocked_manifest
+    ):
+        validate_app_type_context(aws_event="mocked", app_decorator_type="mocked")
+
+
+def test__read_correct_manifest_file__success(context):
+    """Test when manifest.json exists and contains valid JSON."""
+    manifest_payload = {"application": {"type": "stream"}}
+    manifest_payload_json = json.dumps(manifest_payload)
+
+    with (
+        mock.patch("os.path.exists", return_value=True),
+        mock.patch("builtins.open", mock.mock_open(read_data=manifest_payload_json)),
+    ):
+        result = read_manifest()
+        assert result == manifest_payload
+
+
+def test__read_invalid_json_manifest_file__error(context):
+    """Test when manifest.json contains invalid JSON."""
+    manifest_invalid_json = "{invalid: json}"
+
+    with (
+        mock.patch("os.path.exists", return_value=True),
+        mock.patch("builtins.open", mock.mock_open(read_data=manifest_invalid_json)),
+    ):
+        with pytest.raises(json.JSONDecodeError):
+            read_manifest()
+
+
+def test__manifest_file_not_exists__success(context):
+    """Test when manifest.json contains invalid JSON."""
+    with mock.patch("os.path.exists", return_value=False):
+        result = read_manifest()
+        assert result is None