Removed the exclusions for defaulted values from required checking. (#706)

Closes #705

Author: mwadams

Solutions/Corvus.Json.CodeGeneration.CSharp/Corvus.Json.CodeGeneration/CSharp/ValidationHandlers/ObjectChildHandlers/PropertiesValidationHandler.cs

@@ -96,8 +96,7 @@ static void AppendPropertyValidation(CodeGenerator generator, PropertyDeclaratio
                 .AppendLineIndent("{")
                 .PushIndent();
 
-            if (property.RequiredOrOptional == RequiredOrOptional.Required &&
-                !property.ReducedPropertyType.HasDefaultValue())
+            if (property.RequiredOrOptional == RequiredOrOptional.Required)
             {
                 string hasSeenField = RequiredValidationHandler.GetHasSeenVariableName(generator, property);
                 generator

Solutions/Corvus.Json.CodeGeneration.CSharp/Corvus.Json.CodeGeneration/CSharp/ValidationHandlers/ObjectChildHandlers/RequiredValidationHandler.cs

@@ -37,8 +37,7 @@ public CodeGenerator AppendValidationCode(CodeGenerator generator, TypeDeclarati
                     return generator;
                 }
 
-                // Don't bother with properties that have default values.
-                if (property.ReducedPropertyType.HasDefaultValue() || property.RequiredKeyword is not IObjectRequiredPropertyValidationKeyword keyword)
+                if (property.RequiredKeyword is not IObjectRequiredPropertyValidationKeyword keyword)
                 {
                     continue;
                 }
@@ -140,12 +139,6 @@ public CodeGenerator AppendValidateMethodSetup(CodeGenerator generator, TypeDecl
                     return generator;
                 }
 
-                // Don't bother with properties that have default values.
-                if (property.ReducedPropertyType.HasDefaultValue())
-                {
-                    continue;
-                }
-
                 string requiredName = GetHasSeenVariableName(generator, property);
                 generator
                     .AppendLineIndent("bool ", requiredName, " = false;");

Solutions/Corvus.Json.Specs/Features/AdditionalSchema/Draft202012/Repro705.feature

@@ -0,0 +1,33 @@
+@draft202012
+
+Feature: Repro 705 draft202012
+
+Scenario Outline: Defaulted required property 
+	Given a schema file
+		"""
+		{
+			"type": "object",
+			"properties": {
+				"regularProperty": { "type": "string" },
+				"propertyWithDefault": { "$ref": "#/$defs/defaultedValue" },
+				"unsetProperty": { "type": "string" }
+			},
+			"required": ["regularProperty", "propertyWithDefault"],
+			"$defs": {
+				"defaultedValue": {
+					"type": "string",
+					"default": "Hello"
+				}
+			}
+		}
+		"""
+	And the input data value <inputData>
+	And I generate a type for the schema
+	And I construct an instance of the schema type from the data
+	When I validate the instance with level Detailed
+	Then the result will be <valid>
+
+Examples:
+	| inputData                                                | valid |
+	| {"regularProperty": "foo"}                               | false |
+	| {"regularProperty": "foo", "propertyWithDefault": "bar"} | true  |