Skip to content

Commit 64f6630

Browse files
committed
explain test conditional in news + update one visual regression test
1 parent ecf582c commit 64f6630

3 files changed

Lines changed: 28 additions & 23 deletions

File tree

NEWS.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@
44

55
The paramater `outline.type` from `ggplot2::geom_ribbon()` has been adapted to `geom_alluvium()` and `geom_flow()` with the same options and default.
66

7+
## remove test dependency on {alluvial}
8+
9+
The tests that use the `Refugees` data set from **alluvial** are now only run if that package is installed; see #131 and thanks to @MichaelChirico.
10+
711
# ggalluvial 0.12.5
812

913
This patch fixes a bug involving the {dplyr} functions `first()` and `last()` that was shifted but not fixed in 0.12.4. Rather than being imported during build, they are accessed internally and thus imported during use. See issues #107 <https://github.com/corybrunson/ggalluvial/issues/107> and #108 <https://github.com/corybrunson/ggalluvial/issues/108> on GitHub for details.
@@ -12,7 +16,7 @@ This patch fixes a bug involving the {dplyr} functions `first()` and `last()` th
1216

1317
## `linewidth` aesthetic (breaking change)
1418

15-
An upcoming release of *ggplot2* controls stroke width using the new `linewidth` aesthetic rather than `size`. This release adapts to this change internally by updating row and column layers as recommended here: <https://www.tidyverse.org/blog/2022/08/ggplot2-3-4-0-size-to-linewidth/>
19+
An upcoming release of **ggplot2** controls stroke width using the new `linewidth` aesthetic rather than `size`. This release adapts to this change internally by updating row and column layers as recommended here: <https://www.tidyverse.org/blog/2022/08/ggplot2-3-4-0-size-to-linewidth/>
1620

1721
## Curve constructors
1822

tests/testthat/_snaps/geom-lode/geom-lode-one-axis.svg

Lines changed: 18 additions & 18 deletions
Loading

tests/testthat/test-geom-alluvium.r

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,10 @@
33
test_that("`geom_alluvium` draws correctly", {
44
skip_on_cran()
55
skip_if_not_installed("vdiffr")
6-
skip_if_not_installed("alluvial")
76

87
d1 <- as.data.frame(Titanic)
98
a1 <- aes(y = Freq, axis1 = Class, axis2 = Sex, axis3 = Age, fill = Survived)
109
a2 <- aes(y = Freq, axis1 = Class, axis2 = Sex)
11-
d2 <- alluvial::Refugees
12-
a3 <- aes(y = refugees, x = year, alluvium = country)
13-
1410
vdiffr::expect_doppelganger(
1511
"`geom_alluvium`: basic",
1612
ggplot(d1, a1) + geom_alluvium()
@@ -21,6 +17,11 @@ test_that("`geom_alluvium` draws correctly", {
2117
geom_alluvium(aes(fill = Age), width = .4) +
2218
facet_wrap(~ Survived, scales = "fixed")
2319
)
20+
21+
skip_if_not_installed("alluvial")
22+
23+
d2 <- alluvial::Refugees
24+
a3 <- aes(y = refugees, x = year, alluvium = country)
2425
vdiffr::expect_doppelganger(
2526
"`geom_alluvium`: bump plot",
2627
ggplot(d2, a3) +

0 commit comments

Comments
 (0)