Skip to content

Commit 1ff1bcd

Browse files
committed
address checks
1 parent 4d837de commit 1ff1bcd

2 files changed

Lines changed: 22 additions & 9 deletions

File tree

DESCRIPTION

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ Depends:
3737
ggplot2
3838
Imports:
3939
rlang,
40+
tidyr,
41+
dplyr,
4042
magrittr,
4143
scales,
4244
labeling,

cran-comments.md

Lines changed: 20 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
## version 0.1.0
22

3-
This is the initial release.
3+
This is a new submission of the initial release of {gggda}.
44
Local checks were performed both with the current CRAN version 3.5.2 of {ggplot2} and with the current development version (2025 Jun 30).
55

66
## R CMD checks
@@ -18,6 +18,7 @@ Local checks were performed both with the current CRAN version 3.5.2 of {ggplot2
1818

1919
### local results
2020

21+
There were no ERRORs or WARNINGs.
2122
Two NOTEs were consistently produced:
2223

2324
```
@@ -29,11 +30,26 @@ Two NOTEs were consistently produced:
2930
```
3031

3132
The first is intentional, as in {ordr}; the relevant functionality locates any of three "engine" packages to run the required operation.
32-
The second is a recurring pattern in my checks, presumably due to internet speeds.
33+
The second is presumably due to internet speeds.
34+
35+
The third check additionally produced the "New submission" NOTE as well as the following NOTE:
36+
37+
```
38+
❯ checking dependencies in R code ... NOTE
39+
Namespaces in Imports field not imported from:
40+
‘dplyr’ ‘tidyr’
41+
All declared Imports should be used.
42+
```
43+
44+
I believe this is in error; both packages are used internally via the double-colon operator `::`.
3345

3446
### Win-Builder results
3547

48+
There were no ERRORs or WARNINGs.
49+
Notably, the "not imported" NOTE did not arise.
50+
All NOTEs not seen above are addressed below.
3651

52+
The following names and words are spelled as intended ("al" appears as part of "&al"):
3753

3854
```
3955
Possibly misspelled words in DESCRIPTION:
@@ -50,15 +66,10 @@ Possibly misspelled words in DESCRIPTION:
5066
univariable (13:60)
5167
```
5268

53-
69+
The following URLs work for me:
5470

5571
```
5672
Found the following (possibly) invalid URLs:
57-
URL: https://corybrunson.github.io/gggda/
58-
From: DESCRIPTION
59-
man/gggda.Rd
60-
Status: 404
61-
Message: Not Found
6273
URL: https://stackoverflow.com/help/minimal-reproducible-example
6374
From: README.md
6475
Status: 404
@@ -67,5 +78,5 @@ Found the following (possibly) invalid URLs:
6778
From: inst/doc/gggda.html
6879
Status: Error
6980
Message: Timeout was reached [www.jud.ct.gov]:
70-
Failed to connect to www.jud.ct.gov port 443 after 21296 ms: Could not connect to server
81+
Failed to connect to www.jud.ct.gov port 443 after 21050 ms: Could not connect to server
7182
```

0 commit comments

Comments
 (0)