Skip to content

Commit 532013b

Browse files
committed
update per tests with mlpack installed & patch to 0.1.1
1 parent 91e7e82 commit 532013b

1 file changed

Lines changed: 4 additions & 46 deletions

File tree

cran-comments.md

Lines changed: 4 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
With apologies to the CRAN team, this patch fixes a bug that arose while debugging the last issue before submission.
44
Tests have been introduced to catch similar bugs in future.
55

6+
The patch also addresses the problems flagged in the current CRAN checks by explicitly importing the reqired functions from {dplyr} and {tidyr}.
7+
68
## R CMD checks
79

810
### Test environments
@@ -18,57 +20,13 @@ Tests have been introduced to catch similar bugs in future.
1820

1921
### local results
2022

21-
There were no ERRORs or WARNINGs.
22-
Two NOTEs were consistently produced:
23-
24-
```
25-
❯ checking package dependencies ... NOTE
26-
Package suggested but not available for checking: ‘mlpack’
27-
28-
❯ checking for future file timestamps ... NOTE
29-
unable to verify current time
30-
```
31-
32-
The first is intentional, as in {ordr}; the relevant functionality locates any of three "engine" packages to run the required operation.
33-
The second is presumably due to internet speeds.
34-
35-
The third check additionally produced the "New submission" NOTE.
36-
37-
Some checks also produced the following NOTE:
38-
39-
```
40-
❯ checking dependencies in R code ... NOTE
41-
Namespaces in Imports field not imported from:
42-
‘dplyr’ ‘tidyr’
43-
All declared Imports should be used.
44-
```
45-
46-
I believe this is in error; both packages are used internally via the double-colon operator `::`.
23+
There were no ERRORs, WARNINGs, or NOTEs.
4724

4825
### Win-Builder results
4926

5027
There were no ERRORs or WARNINGs.
51-
Notably, the "not imported" NOTE did not arise.
52-
All NOTEs not seen above are addressed below.
53-
54-
The following names and words are spelled as intended ("al" appears as part of "&al"):
55-
56-
```
57-
Possibly misspelled words in DESCRIPTION:
58-
Gower (25:5)
59-
Jolliffe (19:5)
60-
Podani (28:74)
61-
Rouanet (30:5)
62-
Rousseeuw (17:43)
63-
Wickham's (31:5)
64-
al (17:54)
65-
biplots (21:19)
66-
bivariate (15:33)
67-
multivariable (12:27, 14:19, 27:64)
68-
univariable (13:60)
69-
```
7028

71-
The following URLs work for me:
29+
The following URLs were each NOTEd by one or more checks but work for me:
7230

7331
```
7432
Found the following (possibly) invalid URLs:

0 commit comments

Comments
 (0)