fix: provide more details on buffer overrun mode

This allows to see details of the overrun if it happens.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>

Author: smira

.drone.yml

@@ -1,7 +1,7 @@
 ---
 # THIS FILE WAS AUTOMATICALLY GENERATED, PLEASE DO NOT EDIT.
 #
-# Generated on 2025-04-16T09:43:54Z by kres fd5cab0.
+# Generated on 2025-05-06T13:52:04Z by kres 1a0156b.
 
 kind: pipeline
 type: kubernetes
@@ -270,7 +270,7 @@ steps:
 
 services:
 - name: docker
-  image: docker:28.0-dind
+  image: docker:28.1-dind
   entrypoint:
   - dockerd
   commands:

.golangci.yml

@@ -1,6 +1,6 @@
 # THIS FILE WAS AUTOMATICALLY GENERATED, PLEASE DO NOT EDIT.
 #
-# Generated on 2025-04-16T09:43:54Z by kres fd5cab0.
+# Generated on 2025-05-06T13:52:04Z by kres 1a0156b.
 
 version: "2"
 
@@ -48,6 +48,7 @@ linters:
     - protogetter # complains about us using Value field on typed spec, instead of GetValue which has a different signature
     - perfsprint # complains about us using fmt.Sprintf in non-performance critical code, updating just kres took too long
     - musttag # seems to be broken - goes into imported libraries and reports issues there
+    - nolintlint # gives false positives - disable until https://github.com/golangci/golangci-lint/issues/3228 is resolved
   # all available settings of specific linters
   settings:
     cyclop:
@@ -89,11 +90,6 @@ linters:
       simple: true
       range-loops: true # Report preallocation suggestions on range loops, true by default
       for-loops: false # Report preallocation suggestions on for loops, false by default
-    nolintlint:
-      allow-unused: false
-      allow-no-explanation: [ ]
-      require-explanation: false
-      require-specific: true
     rowserrcheck: { }
     testpackage: { }
     unparam:

Dockerfile

@@ -1,8 +1,8 @@
-# syntax = docker/dockerfile-upstream:1.14.1-labs
+# syntax = docker/dockerfile-upstream:1.15.1-labs
 
 # THIS FILE WAS AUTOMATICALLY GENERATED, PLEASE DO NOT EDIT.
 #
-# Generated on 2025-04-16T09:43:54Z by kres fd5cab0.
+# Generated on 2025-05-06T13:52:04Z by kres 1a0156b.
 
 ARG TOOLCHAIN
 
@@ -11,7 +11,7 @@ FROM ghcr.io/siderolabs/ca-certificates:v1.10.0 AS image-ca-certificates
 FROM ghcr.io/siderolabs/fhs:v1.10.0 AS image-fhs
 
 # runs markdownlint
-FROM docker.io/oven/bun:1.2.9-alpine AS lint-markdown
+FROM docker.io/oven/bun:1.2.11-alpine AS lint-markdown
 WORKDIR /src
 RUN bun i markdownlint-cli@0.44.0 sentences-per-line@0.3.0
 COPY .markdownlint.json .

Makefile

@@ -1,6 +1,6 @@
 # THIS FILE WAS AUTOMATICALLY GENERATED, PLEASE DO NOT EDIT.
 #
-# Generated on 2025-04-16T09:43:54Z by kres fd5cab0.
+# Generated on 2025-05-06T13:52:04Z by kres 1a0156b.
 
 # common variables
 
@@ -22,9 +22,9 @@ GRPC_GO_VERSION ?= 1.5.1
 GRPC_GATEWAY_VERSION ?= 2.26.3
 VTPROTOBUF_VERSION ?= 0.6.0
 GOIMPORTS_VERSION ?= 0.32.0
-GOMOCK_VERSION ?= 0.5.1
+GOMOCK_VERSION ?= 0.5.2
 DEEPCOPY_VERSION ?= v0.5.6
-GOLANGCILINT_VERSION ?= v2.1.1
+GOLANGCILINT_VERSION ?= v2.1.5
 GOFUMPT_VERSION ?= v0.8.0
 GO_VERSION ?= 1.24.2
 GO_BUILDFLAGS ?=

pkg/controller/generic/qtransform/qtransform_test.go

@@ -621,7 +621,7 @@ func TestDestroyInputFinalizers(t *testing.T) {
 
 		// controller should remove finalizer on inputs
 		rtestutils.AssertResources(ctx, t, st, []resource.ID{"2"}, func(r *A, assert *assert.Assertions) {
-			assert.True(r.Metadata().Finalizers().Add("TransformABController"))
+			assert.False(r.Metadata().Finalizers().Has("QTransformABController"))
 		})
 
 		require.NoError(t, st.Destroy(ctx, NewA("2", ASpec{}).Metadata()))

pkg/controller/runtime/internal/cache/cache_test.go

@@ -28,6 +28,8 @@ func resourceIDGenerator(i int) resource.ID {
 }
 
 func TestCacheOperations(t *testing.T) {
+	metrics.CachedResources.Init()
+
 	ctx, cancel := context.WithTimeout(t.Context(), 10*time.Second)
 	defer cancel()
 

pkg/resource/protobuf/registry_test.go

@@ -7,6 +7,7 @@ package protobuf_test
 import (
 	"testing"
 
+	"github.com/siderolabs/gen/ensure"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 
@@ -15,9 +16,11 @@ import (
 	"github.com/cosi-project/runtime/pkg/state/conformance"
 )
 
-func BenchmarkCreateResource(b *testing.B) {
-	_ = protobuf.RegisterResource(conformance.PathResourceType, &conformance.PathResource{}) //nolint:errcheck
+func init() {
+	ensure.NoError(protobuf.RegisterResource(conformance.PathResourceType, &conformance.PathResource{}))
+}
 
+func BenchmarkCreateResource(b *testing.B) {
 	protoR := &v1alpha1.Resource{
 		Metadata: &v1alpha1.Metadata{
 			Namespace: "ns",
@@ -53,8 +56,6 @@ func BenchmarkCreateResource(b *testing.B) {
 func TestRegistry(t *testing.T) {
 	t.Parallel()
 
-	require.NoError(t, protobuf.RegisterResource(conformance.PathResourceType, &conformance.PathResource{}))
-
 	protoR := &v1alpha1.Resource{
 		Metadata: &v1alpha1.Metadata{
 			Namespace: "ns",

pkg/state/impl/inmem/collection.go

@@ -399,12 +399,17 @@ func (collection *ResourceCollection) Watch(ctx context.Context, id resource.ID,
 			}
 
 			if collection.writePos-pos > int64(collection.capacity) {
+				collectionWritePos, collectionCapacity := collection.writePos, collection.capacity
+
 				collection.mu.Unlock()
 
 				channel.SendWithContext(ctx, ch,
 					state.Event{
-						Type:  state.Errored,
-						Error: fmt.Errorf("buffer overrun: namespace %q type %q", collection.ns, collection.typ),
+						Type: state.Errored,
+						Error: fmt.Errorf(
+							"buffer overrun: namespace %q type %q, write pos %d, pos %d, capacity %d",
+							collection.ns, collection.typ, collectionWritePos, pos, collectionCapacity,
+						),
 					},
 				)
 
@@ -608,11 +613,16 @@ func (collection *ResourceCollection) WatchAll(ctx context.Context, singleCh cha
 			}
 
 			if collection.writePos-pos > int64(collection.capacity) {
+				collectionWritePos, collectionCapacity := collection.writePos, collection.capacity
+
 				collection.mu.Unlock()
 
 				overrunEvent := state.Event{
-					Type:  state.Errored,
-					Error: fmt.Errorf("buffer overrun: namespace %q type %q", collection.ns, collection.typ),
+					Type: state.Errored,
+					Error: fmt.Errorf(
+						"buffer overrun: namespace %q type %q, write pos %d, pos %d, capacity %d",
+						collection.ns, collection.typ, collectionWritePos, pos, collectionCapacity,
+					),
 				}
 
 				switch {

pkg/state/impl/inmem/local_test.go

@@ -117,7 +117,7 @@ watchKindChLoop:
 
 			// buffer overrun
 			require.Equal(t, state.Errored, ev.Type)
-			require.EqualError(t, ev.Error, fmt.Sprintf("buffer overrun: namespace %q type %q", namespace, conformance.PathResourceType))
+			require.ErrorContains(t, ev.Error, fmt.Sprintf("buffer overrun: namespace %q type %q", namespace, conformance.PathResourceType))
 
 			break watchKindChLoop
 		case <-time.After(time.Second):
@@ -145,7 +145,7 @@ watchLoop:
 
 			// buffer overrun
 			require.Equal(t, state.Errored, ev.Type)
-			require.EqualError(t, ev.Error, fmt.Sprintf("buffer overrun: namespace %q type %q", namespace, conformance.PathResourceType))
+			require.ErrorContains(t, ev.Error, fmt.Sprintf("buffer overrun: namespace %q type %q", namespace, conformance.PathResourceType))
 
 			break watchLoop
 		case <-time.After(time.Second):

pkg/state/impl/store/bolt/bbolt_test.go

@@ -8,6 +8,7 @@ import (
 	"path/filepath"
 	"testing"
 
+	"github.com/siderolabs/gen/ensure"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 	"go.etcd.io/bbolt"
@@ -19,11 +20,13 @@ import (
 	"github.com/cosi-project/runtime/pkg/state/impl/store/bolt"
 )
 
+func init() {
+	ensure.NoError(protobuf.RegisterResource(conformance.PathResourceType, &conformance.PathResource{}))
+}
+
 func TestBboltStore(t *testing.T) { //nolint:tparallel
 	t.Parallel()
 
-	require.NoError(t, protobuf.RegisterResource(conformance.PathResourceType, &conformance.PathResource{}))
-
 	tmpDir := t.TempDir()
 
 	marshaler := store.ProtobufMarshaler{}