tACK

Author: julienrbrt

CHANGELOG.md

@@ -72,6 +72,8 @@ Ref: https://keepachangelog.com/en/1.0.0/
 * (server) [#24072](https://github.com/cosmos/cosmos-sdk/pull/24072) Return BlockHeader by shallow copy in server Context.
 * (x/bank) [#24053](https://github.com/cosmos/cosmos-sdk/pull/24053) Resolve a foot-gun by swapping send restrictions check in `InputOutputCoins` before coin deduction.
 * (codec/types) [#24336](https://github.com/cosmos/cosmos-sdk/pull/24336) Most types definitions were moved to `github.com/cosmos/gogoproto/types/any` with aliases to these left in `codec/types` so that there should be no breakage to existing code. This allows protobuf generated code to optionally reference the SDK's custom `Any` type without a direct dependency on the SDK. This can be done by changing the `protoc` `M` parameter for `any.proto` to `Mgoogle/protobuf/any.proto=github.com/cosmos/gogoproto/types/any`.
+* [#24387](https://github.com/cosmos/cosmos-sdk/pull/24387) Add commands for all proposals thanks to AutoCLI. Additionally, improve UX commands thanks to AutoCLI:
+    * f.e `<appd> tx bank send alice $(simd keys show bob -a) 100stake` can be directly `<appd> tx bank send alice bob 100stake` now. This is true for all fields that take an address.
 
 ### Bug Fixes
 

x/auth/vesting/client/cli/tx.go

@@ -34,8 +34,6 @@ func GetTxCmd(ac address.Codec) *cobra.Command {
 	}
 
 	txCmd.AddCommand(
-		NewMsgCreateVestingAccountCmd(ac),
-		NewMsgCreatePermanentLockedAccountCmd(ac),
 		NewMsgCreatePeriodicVestingAccountCmd(ac),
 	)
 
@@ -44,6 +42,8 @@ func GetTxCmd(ac address.Codec) *cobra.Command {
 
 // NewMsgCreateVestingAccountCmd returns a CLI command handler for creating a
 // MsgCreateVestingAccount transaction.
+// Deprecated: This command is deprecated and will be removed in a future release.
+// The module is using its AutoCLI command instead.
 func NewMsgCreateVestingAccountCmd(ac address.Codec) *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "create-vesting-account [to_address] [amount] [end_time]",
@@ -91,8 +91,9 @@ timestamp.`,
 	return cmd
 }
 
-// NewMsgCreatePermanentLockedAccountCmd returns a CLI command handler for creating a
-// MsgCreatePermanentLockedAccount transaction.
+// NewMsgCreatePermanentLockedAccountCmd returns a CLI command handler for creating a MsgCreatePermanentLockedAccount transaction.
+// Deprecated: This command is deprecated and will be removed in a future release.
+// The module is using its AutoCLI command instead.
 func NewMsgCreatePermanentLockedAccountCmd(ac address.Codec) *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "create-permanent-locked-account [to_address] [amount]",

x/authz/client/cli/tx.go

@@ -47,7 +47,6 @@ func GetTxCmd(ac address.Codec) *cobra.Command {
 
 	AuthorizationTxCmd.AddCommand(
 		NewCmdGrantAuthorization(ac),
-		NewCmdRevokeAuthorization(ac),
 		NewCmdExecAuthorization(),
 	)
 
@@ -229,6 +228,8 @@ func getExpireTime(cmd *cobra.Command) (*time.Time, error) {
 }
 
 // NewCmdRevokeAuthorization returns a CLI command handler for creating a MsgRevoke transaction.
+// Deprecated: This command is deprecated and will be removed in a future release.
+// The module is using its AutoCLI command instead.
 func NewCmdRevokeAuthorization(ac address.Codec) *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "revoke [grantee] [msg-type-url] --from=[granter]",

x/distribution/client/cli/tx.go

@@ -38,11 +38,7 @@ func NewTxCmd(valAc, ac address.Codec) *cobra.Command {
 	}
 
 	distTxCmd.AddCommand(
-		NewWithdrawRewardsCmd(valAc, ac),
 		NewWithdrawAllRewardsCmd(valAc, ac),
-		NewSetWithdrawAddrCmd(ac),
-		NewFundCommunityPoolCmd(ac),
-		NewDepositValidatorRewardsPoolCmd(valAc, ac),
 	)
 
 	return distTxCmd
@@ -72,6 +68,8 @@ func newSplitAndApply(
 }
 
 // NewWithdrawRewardsCmd returns a CLI command handler for creating a MsgWithdrawDelegatorReward transaction.
+// Deprecated: This command is deprecated and will be removed in a future release.
+// The module is using its AutoCLI command instead.
 func NewWithdrawRewardsCmd(valCodec, ac address.Codec) *cobra.Command {
 	bech32PrefixValAddr := sdk.GetConfig().GetBech32ValidatorAddrPrefix()
 
@@ -185,6 +183,8 @@ $ %[1]s tx distribution withdraw-all-rewards --from mykey
 }
 
 // NewSetWithdrawAddrCmd returns a CLI command handler for creating a MsgSetWithdrawAddress transaction.
+// Deprecated: This command is deprecated and will be removed in a future release.
+// The module is using its AutoCLI command instead.
 func NewSetWithdrawAddrCmd(ac address.Codec) *cobra.Command {
 	bech32PrefixAccAddr := sdk.GetConfig().GetBech32AccountAddrPrefix()
 
@@ -224,6 +224,8 @@ $ %s tx distribution set-withdraw-addr %s1gghjut3ccd8ay0zduzj64hwre2fxs9ld75ru9p
 }
 
 // NewFundCommunityPoolCmd returns a CLI command handler for creating a MsgFundCommunityPool transaction.
+// Deprecated: This command is deprecated and will be removed in a future release.
+// The module is using its AutoCLI command instead.
 func NewFundCommunityPoolCmd(ac address.Codec) *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "fund-community-pool [amount]",
@@ -265,6 +267,8 @@ $ %s tx distribution fund-community-pool 100uatom --from mykey
 
 // NewDepositValidatorRewardsPoolCmd returns a CLI command handler for creating
 // a MsgDepositValidatorRewardsPool transaction.
+// Deprecated: This command is deprecated and will be removed in a future release.
+// The module is using its AutoCLI command instead.
 func NewDepositValidatorRewardsPoolCmd(valCodec, ac address.Codec) *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "fund-validator-rewards-pool [val_addr] [amount]",

x/gov/client/cli/tx.go

@@ -68,12 +68,9 @@ func NewTxCmd(legacyPropCmds []*cobra.Command) *cobra.Command {
 	}
 
 	govTxCmd.AddCommand(
-		NewCmdDeposit(),
-		NewCmdVote(),
 		NewCmdWeightedVote(),
 		NewCmdSubmitProposal(),
 		NewCmdDraftProposal(),
-		NewCmdCancelProposal(),
 
 		// Deprecated
 		cmdSubmitLegacyProp,
@@ -155,6 +152,8 @@ metadata example:
 }
 
 // NewCmdCancelProposal implements submitting a cancel proposal transaction command.
+// Deprecated: This command is deprecated and will be removed in a future release.
+// The module is using its AutoCLI command instead.
 func NewCmdCancelProposal() *cobra.Command {
 	cmd := &cobra.Command{
 		Use:     "cancel-proposal [proposal-id]",
@@ -254,6 +253,8 @@ $ %s tx gov submit-legacy-proposal --title="Test Proposal" --description="My awe
 }
 
 // NewCmdDeposit implements depositing tokens for an active proposal.
+// Deprecated: This command is deprecated and will be removed in a future release.
+// The module is using its AutoCLI command instead.
 func NewCmdDeposit() *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "deposit [proposal-id] [deposit]",
@@ -302,6 +303,8 @@ $ %s tx gov deposit 1 10stake --from mykey
 }
 
 // NewCmdVote implements creating a new vote command.
+// Deprecated: This command is deprecated and will be removed in a future release.
+// The module is using its AutoCLI command instead.
 func NewCmdVote() *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "vote [proposal-id] [option]",

x/group/client/cli/tx.go

@@ -38,19 +38,11 @@ func TxCmd(name string, ac address.Codec) *cobra.Command {
 
 	txCmd.AddCommand(
 		MsgCreateGroupCmd(),
-		MsgUpdateGroupAdminCmd(),
-		MsgUpdateGroupMetadataCmd(),
 		MsgUpdateGroupMembersCmd(),
 		MsgCreateGroupWithPolicyCmd(),
 		MsgCreateGroupPolicyCmd(),
-		MsgUpdateGroupPolicyAdminCmd(),
 		MsgUpdateGroupPolicyDecisionPolicyCmd(ac),
-		MsgUpdateGroupPolicyMetadataCmd(),
-		MsgWithdrawProposalCmd(),
 		MsgSubmitProposalCmd(),
-		MsgVoteCmd(),
-		MsgExecCmd(),
-		MsgLeaveGroupCmd(),
 		NewCmdDraftProposal(),
 	)
 
@@ -196,6 +188,8 @@ Set a member's weight to "0" to delete it.
 }
 
 // MsgUpdateGroupAdminCmd creates a CLI command for Msg/UpdateGroupAdmin.
+// Deprecated: This command is deprecated and will be removed in a future release.
+// The module is using its AutoCLI command instead.
 func MsgUpdateGroupAdminCmd() *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "update-group-admin [admin] [group-id] [new-admin]",
@@ -240,6 +234,8 @@ func MsgUpdateGroupAdminCmd() *cobra.Command {
 }
 
 // MsgUpdateGroupMetadataCmd creates a CLI command for Msg/UpdateGroupMetadata.
+// Deprecated: This command is deprecated and will be removed in a future release.
+// The module is using its AutoCLI command instead.
 func MsgUpdateGroupMetadataCmd() *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "update-group-metadata [admin] [group-id] [metadata]",
@@ -457,6 +453,8 @@ Here, we can use percentage decision policy when needed, where 0 < percentage <=
 }
 
 // MsgUpdateGroupPolicyAdminCmd creates a CLI command for Msg/UpdateGroupPolicyAdmin.
+// Deprecated: This command is deprecated and will be removed in a future release.
+// The module is using its AutoCLI command instead.
 func MsgUpdateGroupPolicyAdminCmd() *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "update-group-policy-admin [admin] [group-policy-account] [new-admin]",
@@ -537,6 +535,8 @@ func MsgUpdateGroupPolicyDecisionPolicyCmd(ac address.Codec) *cobra.Command {
 }
 
 // MsgUpdateGroupPolicyMetadataCmd creates a CLI command for Msg/UpdateGroupPolicyMetadata.
+// Deprecated: This command is deprecated and will be removed in a future release.
+// The module is using its AutoCLI command instead.
 func MsgUpdateGroupPolicyMetadataCmd() *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "update-group-policy-metadata [admin] [group-policy-account] [new-metadata]",
@@ -660,6 +660,8 @@ metadata example:
 }
 
 // MsgWithdrawProposalCmd creates a CLI command for Msg/WithdrawProposal.
+// Deprecated: This command is deprecated and will be removed in a future release.
+// The module is using its AutoCLI command instead.
 func MsgWithdrawProposalCmd() *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "withdraw-proposal [proposal-id] [group-policy-admin-or-proposer]",
@@ -706,6 +708,8 @@ Parameters:
 }
 
 // MsgVoteCmd creates a CLI command for Msg/Vote.
+// Deprecated: This command is deprecated and will be removed in a future release.
+// The module is using its AutoCLI command instead.
 func MsgVoteCmd() *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "vote [proposal-id] [voter] [vote-option] [metadata]",
@@ -766,6 +770,8 @@ Parameters:
 }
 
 // MsgExecCmd creates a CLI command for Msg/Exec.
+// Deprecated: This command is deprecated and will be removed in a future release.
+// The module is using its AutoCLI command instead.
 func MsgExecCmd() *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "exec [proposal-id]",
@@ -797,6 +803,8 @@ func MsgExecCmd() *cobra.Command {
 }
 
 // MsgLeaveGroupCmd creates a CLI command for Msg/LeaveGroup.
+// Deprecated: This command is deprecated and will be removed in a future release.
+// The module is using its AutoCLI command instead.
 func MsgLeaveGroupCmd() *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "leave-group [member-address] [group-id]",

x/staking/client/cli/tx.go

@@ -46,10 +46,6 @@ func NewTxCmd(valAddrCodec, ac address.Codec) *cobra.Command {
 	stakingTxCmd.AddCommand(
 		NewCreateValidatorCmd(valAddrCodec),
 		NewEditValidatorCmd(valAddrCodec),
-		NewDelegateCmd(valAddrCodec, ac),
-		NewRedelegateCmd(valAddrCodec, ac),
-		NewUnbondCmd(valAddrCodec, ac),
-		NewCancelUnbondingDelegation(valAddrCodec, ac),
 	)
 
 	return stakingTxCmd
@@ -178,6 +174,8 @@ func NewEditValidatorCmd(ac address.Codec) *cobra.Command {
 }
 
 // NewDelegateCmd returns a CLI command handler for creating a MsgDelegate transaction.
+// Deprecated: This command is deprecated and will be removed in a future release.
+// The module is using its AutoCLI command instead.
 func NewDelegateCmd(valAddrCodec, ac address.Codec) *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "delegate [validator-addr] [amount]",
@@ -224,6 +222,8 @@ $ %s tx staking delegate cosmosvalopers1l2rsakp388kuv9k8qzq6lrm9taddae7fpx59wm 1
 }
 
 // NewRedelegateCmd returns a CLI command handler for creating a MsgBeginRedelegate transaction.
+// Deprecated: This command is deprecated and will be removed in a future release.
+// The module is using its AutoCLI command instead.
 func NewRedelegateCmd(valAddrCodec, ac address.Codec) *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "redelegate [src-validator-addr] [dst-validator-addr] [amount]",
@@ -275,6 +275,8 @@ $ %s tx staking redelegate cosmosvalopers1gghjut3ccd8ay0zduzj64hwre2fxs9ldmqhffj
 }
 
 // NewUnbondCmd returns a CLI command handler for creating a MsgUndelegate transaction.
+// Deprecated: This command is deprecated and will be removed in a future release.
+// The module is using its AutoCLI command instead.
 func NewUnbondCmd(valAddrCodec, ac address.Codec) *cobra.Command {
 	bech32PrefixValAddr := sdk.GetConfig().GetBech32ValidatorAddrPrefix()
 
@@ -323,6 +325,8 @@ $ %s tx staking unbond %s1gghjut3ccd8ay0zduzj64hwre2fxs9ldmqhffj 100stake --from
 }
 
 // NewCancelUnbondingDelegation returns a CLI command handler for creating a MsgCancelUnbondingDelegation transaction.
+// Deprecated: This command is deprecated and will be removed in a future release.
+// The module is using its AutoCLI command instead.
 func NewCancelUnbondingDelegation(valAddrCodec, ac address.Codec) *cobra.Command {
 	bech32PrefixValAddr := sdk.GetConfig().GetBech32ValidatorAddrPrefix()
 

x/upgrade/client/cli/tx.go

@@ -37,7 +37,6 @@ func GetTxCmd(ac addresscodec.Codec) *cobra.Command {
 
 	cmd.AddCommand(
 		NewCmdSubmitUpgradeProposal(ac),
-		NewCmdSubmitCancelUpgradeProposal(ac),
 	)
 
 	return cmd
@@ -133,6 +132,8 @@ func NewCmdSubmitUpgradeProposal(ac addresscodec.Codec) *cobra.Command {
 }
 
 // NewCmdSubmitCancelUpgradeProposal implements a command handler for submitting a software upgrade cancel proposal transaction.
+// Deprecated: This command is deprecated and will be removed in a future release.
+// The module is using its AutoCLI command instead.
 func NewCmdSubmitCancelUpgradeProposal(ac addresscodec.Codec) *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "cancel-software-upgrade [flags]",