Limit signature event size pubKey TxHandler

[robert-zaremba]

Summary of Bug

We are emitting signature events to query transactions by signature. This is the recommended way to query transactions.

The event is created in setPubKey function and the content is created by concatenating all signatures related to the transaction. However, for multisig it can be arbitrary long.

Proposed solution

Instead of emitting an even as a concatenation of all signature data, create a hash of it and use that hash as the event payload.

Version

0.44+

cc: @AmauryM , @aaronc

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[alexanderbez]

Will make client side changes a bit harder, but it saves on event space I suppose 👍

[amaury1093]

I thought event storage was cheap. I'm not sure saving a couple of bytes here is that useful, vs the mental overhead of clients needing to know they need to hash the sig.

[tac0turtle]

This is a super small concern since now events are recommended to be streamed out of the node instead of saving it on the node.

[alexanderbez]

I thought event storage was cheap.

It is :P

[robert-zaremba]

Note: there is ongoing discussion to save events in the app state.

[alexanderbez]

Note: there is ongoing discussion to save events in the app state.

Why? Please, no.

[tac0turtle]

Note: there is ongoing discussion to save events in the app state.

apps are free to do it, but the sdk will not do this natively.