`in-place-testnet` command fails on networks with vote extensions enabled

[johnletey]

Noble heavily utilizes the in-place-testnet command to test upgrades and functionality against state from our live networks. On our devnet, we are testing functionality that requires vote extensions to be enabled. When running the in-place-testnet command, we always get the following error:

panic: failed to reconstruct vote set from extended commit: vote.ValidatorAddress (4AA2B5473063FA3FAB799844EC3519744806FCE5) does not match address (XXX) for vote.ValidatorIndex (0)

Our hunch is that there is missing logic in the testnetify function to properly clean existing vote extensions from the validator set of the live network.

[linear]

SDK-409

[aljo242]

@technicallyty to investigate

[technicallyty]

hey @johnletey i'm having trouble reproing this. however i have a commit where i made a change that might solve the issue though. can you try again with the sdk pinned to b7e74634638c42b30aae80e2f21ef0a33dedd345?

[johnletey]

@technicallyty I'm still getting the same error:

panic: failed to reconstruct vote set from extended commit: vote.ValidatorAddress (4AA2B5473063FA3FAB799844EC3519744806FCE5) does not match address (XXX) for vote.ValidatorIndex (0)
        Ensure the genesis file is correct across all validators: invalid validator address

You can produce this yourself using the v12.0.0-alpha.3 tag on noble-assets/noble, and state sync from our devnet duke-1:

• RPC Address: https://rpc.core.devnet.noble.xyz:443
• Snapshot Interval: 1000 blocks, keep last 2
• Persistent Peer: 4fdd93b6d8f31a475258c5e7145a13989db2bc33@35.159.82.234:26656

[technicallyty]

@technicallyty I'm still getting the same error:

panic: failed to reconstruct vote set from extended commit: vote.ValidatorAddress (4AA2B5473063FA3FAB799844EC3519744806FCE5) does not match address (XXX) for vote.ValidatorIndex (0)
        Ensure the genesis file is correct across all validators: invalid validator address

You can produce this yourself using the v12.0.0-alpha.3 tag on noble-assets/noble, and state sync from our devnet duke-1:

• RPC Address: https://rpc.core.devnet.noble.xyz:443
• Snapshot Interval: 1000 blocks, keep last 2
• Persistent Peer: 4fdd93b6d8f31a475258c5e7145a13989db2bc33@35.159.82.234:26656

Sweet, I will give this a try. Thank you