cache first version for legacy versions (backport #1018) (#1020)

mergify[bot] · yihuang · tac0turtle · web-flow · commit a6e703c21ab8 · 2024-12-16T17:20:12.000Z
Co-authored-by: yihuang &lt;huang@crypto.com&gt;
Co-authored-by: Marko Baricevic &lt;marbar3778@yahoo.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,3 +16,5 @@
 - [#955](https://github.com/cosmos/iavl/pull/955) Get rid of `cosmos-db` deps completely.
 - [#965](https://github.com/cosmos/iavl/pull/965) Use expected interface for expected IAVL `Logger`.
 - [#970](https://github.com/cosmos/iavl/pull/970) Close the pruning process when the nodeDB is closed.
+- [#980](https://github.com/cosmos/iavl/pull/980) Use the `sdk/core/store.KVStoreWithBatch` interface instead of `iavl/db.DB` interface
+- [#1018](https://github.com/cosmos/iavl/pull/1018) Cache first version for legacy versions, fix performance regression after upgrade.
diff --git a/nodedb.go b/nodedb.go
@@ -739,6 +739,7 @@ func (ndb *nodeDB) getFirstVersion() (int64, error) {
 	if itr.Valid() {
 		var version int64
 		legacyRootKeyFormat.Scan(itr.Key(), &version)
+		ndb.resetFirstVersion(version)
 		return version, nil
 	}
 	// Find the first version

Original file line number	Diff line number	Diff line change
`@@ -739,6 +739,7 @@ func (ndb *nodeDB) getFirstVersion() (int64, error) {`
`739`	`739`	`if itr.Valid() {`
`740`	`740`	`var version int64`
`741`	`741`	`legacyRootKeyFormat.Scan(itr.Key(), &version)`
	`742`	`+ ndb.resetFirstVersion(version)`
`742`	`743`	`return version, nil`
`743`	`744`	`}`
`744`	`745`	`// Find the first version`