linter cleanup

Author: faddat

modules/apps/27-interchain-accounts/controller/types/codec_test.go

@@ -1,6 +1,7 @@
 package types_test
 
 import (
+	"errors"
 	"fmt"
 	"testing"
 
@@ -37,7 +38,7 @@ func TestCodecTypeRegistration(t *testing.T) {
 		{
 			"type not registered on codec",
 			"ibc.invalid.MsgTypeURL",
-			fmt.Errorf("unable to resolve type URL"),
+			errors.New("unable to resolve type URL"),
 		},
 	}
 

modules/apps/27-interchain-accounts/host/ibc_module_test.go

@@ -2,7 +2,6 @@ package host_test
 
 import (
 	"errors"
-	"fmt"
 	"strconv"
 	"testing"
 
@@ -276,7 +275,7 @@ func (suite *InterchainAccountsTestSuite) TestOnChanOpenConfirm() {
 				suite.chainB.GetSimApp().ICAAuthModule.IBCApp.OnChanOpenConfirm = func(
 					ctx sdk.Context, portID, channelID string,
 				) error {
-					return fmt.Errorf("mock ica auth fails")
+					return errors.New("mock ica auth fails")
 				}
 			}, nil,
 		},
@@ -410,7 +409,7 @@ func (suite *InterchainAccountsTestSuite) TestOnRecvPacket() {
 				suite.chainB.GetSimApp().ICAAuthModule.IBCApp.OnRecvPacket = func(
 					ctx sdk.Context, channelVersion string, packet channeltypes.Packet, relayer sdk.AccAddress,
 				) exported.Acknowledgement {
-					return channeltypes.NewErrorAcknowledgement(fmt.Errorf("failed OnRecvPacket mock callback"))
+					return channeltypes.NewErrorAcknowledgement(errors.New("failed OnRecvPacket mock callback"))
 				}
 			}, true,
 			"failed OnRecvPacket mock callback",

modules/apps/callbacks/ibc_middleware_test.go

@@ -2,7 +2,9 @@ package ibccallbacks_test
 
 import (
 	"encoding/json"
+	"errors"
 	"fmt"
+	"reflect"
 
 	errorsmod "cosmossdk.io/errors"
 	storetypes "cosmossdk.io/store/types"
@@ -43,28 +45,28 @@ func (s *CallbacksTestSuite) TestNewIBCMiddleware() {
 			func() {
 				_ = ibccallbacks.NewIBCMiddleware(nil, &channelkeeper.Keeper{}, simapp.ContractKeeper{}, maxCallbackGas)
 			},
-			fmt.Errorf("underlying application does not implement %T", (*types.CallbacksCompatibleModule)(nil)),
+			errors.New("underlying application does not implement " + reflect.TypeOf((*types.CallbacksCompatibleModule)(nil)).String()),
 		},
 		{
 			"panics with nil contract keeper",
 			func() {
 				_ = ibccallbacks.NewIBCMiddleware(ibcmock.IBCModule{}, &channelkeeper.Keeper{}, nil, maxCallbackGas)
 			},
-			fmt.Errorf("contract keeper cannot be nil"),
+			errors.New("contract keeper cannot be nil"),
 		},
 		{
 			"panics with nil ics4Wrapper",
 			func() {
 				_ = ibccallbacks.NewIBCMiddleware(ibcmock.IBCModule{}, nil, simapp.ContractKeeper{}, maxCallbackGas)
 			},
-			fmt.Errorf("ICS4Wrapper cannot be nil"),
+			errors.New("ICS4Wrapper cannot be nil"),
 		},
 		{
 			"panics with zero maxCallbackGas",
 			func() {
 				_ = ibccallbacks.NewIBCMiddleware(ibcmock.IBCModule{}, &channelkeeper.Keeper{}, simapp.ContractKeeper{}, uint64(0))
 			},
-			fmt.Errorf("maxCallbackGas cannot be zero"),
+			errors.New("maxCallbackGas cannot be zero"),
 		},
 	}
 
@@ -239,7 +241,7 @@ func (s *CallbacksTestSuite) TestOnAcknowledgementPacket() {
 		userGasLimit uint64
 	)
 
-	panicError := fmt.Errorf("panic error")
+	panicError := errors.New("panic error")
 
 	testCases := []struct {
 		name      string
@@ -582,7 +584,7 @@ func (s *CallbacksTestSuite) TestOnRecvPacket() {
 	)
 
 	successAck := channeltypes.NewResultAcknowledgement([]byte{byte(1)})
-	panicAck := channeltypes.NewErrorAcknowledgement(fmt.Errorf("panic"))
+	panicAck := channeltypes.NewErrorAcknowledgement(errors.New("panic"))
 
 	testCases := []struct {
 		name      string
@@ -855,7 +857,7 @@ func (s *CallbacksTestSuite) TestProcessCallback() {
 		expGasConsumed   uint64
 	)
 
-	callbackError := fmt.Errorf("callbackExecutor error")
+	callbackError := errors.New("callbackExecutor error")
 
 	testCases := []struct {
 		name     string

modules/apps/callbacks/testing/simapp/params/proto.go

@@ -1,5 +1,4 @@
 //go:build !test_amino
-// +build !test_amino
 
 package params
 

modules/apps/callbacks/v2/ibc_middleware_test.go

@@ -238,7 +238,7 @@ func (s *CallbacksTestSuite) TestOnAcknowledgementPacket() {
 		userGasLimit uint64
 	)
 
-	panicError := fmt.Errorf("panic error")
+	panicError := errors.New("panic error")
 
 	testCases := []struct {
 		name      string

modules/apps/transfer/keeper/mbt_relay_test.go

@@ -382,9 +382,9 @@ func (suite *KeeperTestSuite) TestModelBasedRelay() {
 					registerDenomFn()
 					err = suite.chainB.GetSimApp().TransferKeeper.OnAcknowledgementPacket(
 						suite.chainB.GetContext(), packet.SourcePort, packet.SourceChannel, tc.packet.Data,
-						channeltypes.NewErrorAcknowledgement(fmt.Errorf("MBT Error Acknowledgement")))
+						channeltypes.NewErrorAcknowledgement(errors.New("MBT Error Acknowledgement")))
 				default:
-					err = fmt.Errorf("Unknown handler:  %s", tc.handler)
+					err = errors.New("Unknown handler:  " + tc.handler)
 				}
 				if err != nil {
 					suite.Require().False(tc.pass, err.Error())

modules/apps/transfer/keeper/relay_test.go

@@ -657,7 +657,7 @@ func (suite *KeeperTestSuite) TestOnRecvPacketSetsTotalEscrowAmountForSourceIBCT
 func (suite *KeeperTestSuite) TestOnAcknowledgementPacket() {
 	var (
 		successAck      = channeltypes.NewResultAcknowledgement([]byte{byte(1)})
-		failedAck       = channeltypes.NewErrorAcknowledgement(fmt.Errorf("failed packet transfer"))
+		failedAck       = channeltypes.NewErrorAcknowledgement(errors.New("failed packet transfer"))
 		denom           types.Denom
 		amount          sdkmath.Int
 		path            *ibctesting.Path
@@ -796,7 +796,7 @@ func (suite *KeeperTestSuite) TestOnAcknowledgementPacketSetsTotalEscrowAmountFo
 	*/
 
 	amount := defaultAmount
-	ack := channeltypes.NewErrorAcknowledgement(fmt.Errorf("failed packet transfer"))
+	ack := channeltypes.NewErrorAcknowledgement(errors.New("failed packet transfer"))
 
 	// set up
 	// 2 transfer channels between chain A and chain B

modules/apps/transfer/types/denom_test.go

@@ -1,7 +1,7 @@
 package types_test
 
 import (
-	"fmt"
+	"errors"
 	"testing"
 
 	"github.com/stretchr/testify/require"
@@ -36,12 +36,12 @@ func (suite *TypesTestSuite) TestDenomsValidate() {
 				types.NewDenom("uatom", types.NewHop("transfer", "channel-1"), types.NewHop("transfer", "channel-2")),
 				types.NewDenom("uatom", types.NewHop("transfer", "channel-1"), types.NewHop("transfer", "channel-2")),
 			},
-			fmt.Errorf("duplicated denomination with hash"),
+			errors.New("duplicated denomination with hash"),
 		},
 		{
 			"empty base denom with trace",
 			types.Denoms{types.NewDenom("", types.NewHop("transfer", "channel-1"))},
-			fmt.Errorf("base denomination cannot be blank"),
+			errors.New("base denomination cannot be blank"),
 		},
 	}
 

modules/apps/transfer/types/token_test.go

@@ -1,7 +1,7 @@
 package types
 
 import (
-	"fmt"
+	"errors"
 	"testing"
 
 	"github.com/stretchr/testify/require"
@@ -126,7 +126,7 @@ func TestValidate(t *testing.T) {
 				},
 				Amount: amount,
 			},
-			fmt.Errorf("invalid token denom: invalid trace: invalid hop source channel ID : identifier cannot be blank: invalid identifier"),
+			errors.New("invalid token denom: invalid trace: invalid hop source channel ID : identifier cannot be blank: invalid identifier"),
 		},
 		{
 			"failure: empty identifier in trace",
@@ -137,7 +137,7 @@ func TestValidate(t *testing.T) {
 				},
 				Amount: amount,
 			},
-			fmt.Errorf("invalid token denom: invalid trace: invalid hop source port ID : identifier cannot be blank: invalid identifier"),
+			errors.New("invalid token denom: invalid trace: invalid hop source port ID : identifier cannot be blank: invalid identifier"),
 		},
 	}
 

modules/core/02-client/keeper/keeper_test.go

@@ -1,6 +1,7 @@
 package keeper_test
 
 import (
+	"errors"
 	"fmt"
 	"math/rand"
 	"testing"
@@ -623,7 +624,7 @@ func (suite *KeeperTestSuite) TestParams() {
 		{"success: set default params", types.DefaultParams(), nil},
 		{"success: empty allowedClients", types.NewParams(), nil},
 		{"success: subset of allowedClients", types.NewParams(exported.Tendermint, exported.Localhost), nil},
-		{"failure: contains a single empty string value as allowedClient", types.NewParams(exported.Localhost, ""), fmt.Errorf("client type 1 cannot be blank")},
+		{"failure: contains a single empty string value as allowedClient", types.NewParams(exported.Localhost, ""), errors.New("client type 1 cannot be blank")},
 	}
 
 	for _, tc := range testCases {

modules/core/02-client/types/msgs_test.go

@@ -2,7 +2,6 @@ package types_test
 
 import (
 	"errors"
-	"fmt"
 	"testing"
 	"time"
 
@@ -699,7 +698,7 @@ func TestMsgRecoverClientGetSigners(t *testing.T) {
 		expError error
 	}{
 		{"success: valid address", sdk.AccAddress(ibctesting.TestAccAddress), nil},
-		{"failure: nil address", nil, fmt.Errorf("empty address string is not allowed")},
+		{"failure: nil address", nil, errors.New("empty address string is not allowed")},
 	}
 
 	for _, tc := range testCases {
@@ -778,7 +777,7 @@ func TestMsgIBCSoftwareUpgrade_GetSigners(t *testing.T) {
 		{
 			"failure: nil address",
 			nil,
-			fmt.Errorf("empty address string is not allowed"),
+			errors.New("empty address string is not allowed"),
 		},
 	}