Skip to content

Move rate limits to ICS20Transfer #559

@srdtrk

Description

@srdtrk

Description

Right now the rate limits live on the escrow contracts themselves. However, with the upcoming changes in #554, access control will be centralized. This introduces a new issue because AccessManager requires each permission (contractAddress, functionSelector) pair to be registered, this means that as new escrow contracts are deployed, AccessManager needs to be updated.

Until this is done, only the ADMIN_ROLE can call these functions. To improve this, we propose moving rate limits to ICS20. This would also remove the needs for the needless callbacks we perform on the escrow.

Metadata

Metadata

Assignees

No one assigned

    Labels

    20-transferIssues related to the ICS20 applicationenhancementImprovements

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions