- 
                Notifications
    
You must be signed in to change notification settings  - Fork 53
 
Open
Labels
20-transferIssues related to the ICS20 applicationIssues related to the ICS20 applicationenhancementImprovementsImprovements
Description
Description
Right now the rate limits live on the escrow contracts themselves. However, with the upcoming changes in #554, access control will be centralized. This introduces a new issue because AccessManager requires each permission (contractAddress, functionSelector) pair to be registered, this means that as new escrow contracts are deployed, AccessManager needs to be updated.
Until this is done, only the ADMIN_ROLE can call these functions. To improve this, we propose moving rate limits to ICS20. This would also remove the needs for the needless callbacks we perform on the escrow.
Metadata
Metadata
Assignees
Labels
20-transferIssues related to the ICS20 applicationIssues related to the ICS20 applicationenhancementImprovementsImprovements