Skip to content

Commit 586358a

Browse files
committed
fix(ci): rewrite .gitleaksignore comment to avoid self-triggering scanner
Initial commit on this branch included the verbatim trigger phrase in a .gitleaksignore comment, which itself matched generic-api-key — so the allowlist file became its own new finding (PR #182 first run failed fast on .gitleaksignore:6). Rewrite the comment without the quoted phrase or rule keywords; the fingerprint entry alone documents what's allowlisted.
1 parent 50c1de1 commit 586358a

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

.gitleaksignore

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
# Gitleaks fingerprint allowlist.
22
# Format: <commit-sha>:<path>:<rule-id>:<line>
3-
# Add a fingerprint here only after manually verifying the finding is a false positive.
3+
# Add a fingerprint here only after manually verifying the finding.
44

5-
# False positive: gitleaks generic-api-key matches the literal phrase "key:" in a
6-
# Python comment ("# The key: price_50d_ago must be close to price_10d_ago.").
7-
# No real credential. Cannot be suppressed by editing the file because the match
8-
# is in commit history.
5+
# Verified false positive in a Python comment about momentum-strategy bar
6+
# indexing. Source line lives in commit history and cannot be suppressed
7+
# by editing the file in place.
98
6eff1ebbe9074aa261688c52b5a2499734d2a1c1:tests/test_momentum_strategy.py:generic-api-key:147

0 commit comments

Comments
 (0)