Skip to content

Commit ada6e6e

Browse files
committed
Use List.indexOf instead of binary search for SASL
The SASL mechanisms are ordered by preference, so we cannot use binary search for lookup. Change-Id: I1d35799f7b75484c583a8d4a7a286fe2df6b5645 Reviewed-on: http://review.couchbase.org/120616 Reviewed-by: Sergey Avseyev <[email protected]> Tested-by: Sergey Avseyev <[email protected]>
1 parent 3cff70d commit ada6e6e

File tree

1 file changed

+1
-1
lines changed
  • src/main/java/com/couchbase/mock/security/sasl

1 file changed

+1
-1
lines changed

src/main/java/com/couchbase/mock/security/sasl/Sasl.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public class Sasl {
6969
* @throws SaslException If cannot create a SaslServer because of an error.
7070
*/
7171
public static SaslServer createSaslServer(String mechanism, String serverName, Map<String, ?> props, CallbackHandler cbh) throws SaslException {
72-
if (Arrays.binarySearch(ShaSaslServerFactory.SUPPORTED_MECHS, mechanism) < 0) {
72+
if (Arrays.asList(ShaSaslServerFactory.SUPPORTED_MECHS).indexOf( mechanism) < 0) {
7373
return javax.security.sasl.Sasl.createSaslServer(mechanism, PROTOCOL_COUCHBASE, serverName, props, cbh);
7474
} else {
7575
return saslServerFactory.createSaslServer(mechanism, PROTOCOL_COUCHBASE, serverName, props, cbh);

0 commit comments

Comments
 (0)