NCBC-4195: Empty ConnectionPool doesn't resize on authenticator rotation #64
ns-codereviewAnnotations
44 warnings
|
Build and Unit Tests (macos-latest)
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-dotnet@v4, actions/upload-artifact@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Build and Unit Tests (macos-latest):
tests/Couchbase.UnitTests/Core/IO/Operations/OperationBuilderVBucketIdTests.cs#L111
Null should not be used for type parameter 'vbucketId' of type 'short'. Use a non-null value, or convert the parameter to a nullable type. (https://xunit.net/xunit.analyzers/rules/xUnit1012)
|
|
Build and Unit Tests (macos-latest):
tests/Couchbase.UnitTests/Core/IO/Operations/OperationBuilderVBucketIdTests.cs#L111
Null should not be used for type parameter 'vbucketId' of type 'short'. Use a non-null value, or convert the parameter to a nullable type. (https://xunit.net/xunit.analyzers/rules/xUnit1012)
|
|
Build and Unit Tests (macos-latest):
src/Couchbase.Extensions.DependencyInjection/Internal/ClusterProvider.cs#L146
The type 'MemberNotNullAttribute' in '/Users/runner/work/couchbase-net-client/couchbase-net-client/src/Couchbase.Extensions.DependencyInjection/../Couchbase/NullableAttributes.cs' conflicts with the imported type 'MemberNotNullAttribute' in 'Couchbase.NetClient, Version=3.9.1.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in '/Users/runner/work/couchbase-net-client/couchbase-net-client/src/Couchbase.Extensions.DependencyInjection/../Couchbase/NullableAttributes.cs'.
|
|
Build and Unit Tests (macos-latest):
src/Couchbase.Extensions.DependencyInjection/Internal/ClusterProvider.cs#L146
The type 'MemberNotNullAttribute' in '/Users/runner/work/couchbase-net-client/couchbase-net-client/src/Couchbase.Extensions.DependencyInjection/../Couchbase/NullableAttributes.cs' conflicts with the imported type 'MemberNotNullAttribute' in 'Couchbase.NetClient, Version=3.9.1.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in '/Users/runner/work/couchbase-net-client/couchbase-net-client/src/Couchbase.Extensions.DependencyInjection/../Couchbase/NullableAttributes.cs'.
|
|
Build and Unit Tests (macos-latest):
tests/Couchbase.Extensions.OpenTelemetry.IntegrationTests/OtelClusterFixture.cs#L34
'CouchbaseMeterInstrumentationOptions.ExcludeLegacyMetrics' is obsolete: 'Use DropLegacyRedundantCounters instead.'
|
|
Build and Unit Tests (macos-latest):
tests/Couchbase.Extensions.OpenTelemetry.IntegrationTests/OtelClusterFixture.cs#L34
'CouchbaseMeterInstrumentationOptions.ExcludeLegacyMetrics' is obsolete: 'Use DropLegacyRedundantCounters instead.'
|
|
Build and Unit Tests (macos-latest):
tests/Couchbase.UnitTests/Core/IO/Operations/OperationBuilderVBucketIdTests.cs#L111
Null should not be used for type parameter 'vbucketId' of type 'short'. Use a non-null value, or convert the parameter to a nullable type. (https://xunit.net/xunit.analyzers/rules/xUnit1012)
|
|
Build and Unit Tests (macos-latest):
tests/Couchbase.UnitTests/Core/IO/Operations/OperationBuilderVBucketIdTests.cs#L111
Null should not be used for type parameter 'vbucketId' of type 'short'. Use a non-null value, or convert the parameter to a nullable type. (https://xunit.net/xunit.analyzers/rules/xUnit1012)
|
|
Build and Unit Tests (macos-latest):
src/Couchbase.Extensions.DependencyInjection/Internal/ClusterProvider.cs#L146
The type 'MemberNotNullAttribute' in '/Users/runner/work/couchbase-net-client/couchbase-net-client/src/Couchbase.Extensions.DependencyInjection/../Couchbase/NullableAttributes.cs' conflicts with the imported type 'MemberNotNullAttribute' in 'Couchbase.NetClient, Version=3.9.1.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in '/Users/runner/work/couchbase-net-client/couchbase-net-client/src/Couchbase.Extensions.DependencyInjection/../Couchbase/NullableAttributes.cs'.
|
|
Build and Unit Tests (macos-latest):
src/Couchbase.Extensions.DependencyInjection/Internal/ClusterProvider.cs#L146
The type 'MemberNotNullAttribute' in '/Users/runner/work/couchbase-net-client/couchbase-net-client/src/Couchbase.Extensions.DependencyInjection/../Couchbase/NullableAttributes.cs' conflicts with the imported type 'MemberNotNullAttribute' in 'Couchbase.NetClient, Version=3.9.1.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in '/Users/runner/work/couchbase-net-client/couchbase-net-client/src/Couchbase.Extensions.DependencyInjection/../Couchbase/NullableAttributes.cs'.
|
|
Build and Unit Tests (ubuntu-24.04-arm)
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-dotnet@v4, actions/upload-artifact@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Build and Unit Tests (ubuntu-24.04-arm):
src/Couchbase.Extensions.DependencyInjection/Internal/ClusterProvider.cs#L146
The type 'MemberNotNullAttribute' in '/home/runner/work/couchbase-net-client/couchbase-net-client/src/Couchbase.Extensions.DependencyInjection/../Couchbase/NullableAttributes.cs' conflicts with the imported type 'MemberNotNullAttribute' in 'Couchbase.NetClient, Version=3.9.1.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in '/home/runner/work/couchbase-net-client/couchbase-net-client/src/Couchbase.Extensions.DependencyInjection/../Couchbase/NullableAttributes.cs'.
|
|
Build and Unit Tests (ubuntu-24.04-arm):
tests/Couchbase.UnitTests/Core/IO/Operations/OperationBuilderVBucketIdTests.cs#L111
Null should not be used for type parameter 'vbucketId' of type 'short'. Use a non-null value, or convert the parameter to a nullable type. (https://xunit.net/xunit.analyzers/rules/xUnit1012)
|
|
Build and Unit Tests (ubuntu-24.04-arm):
src/Couchbase.Extensions.DependencyInjection/Internal/ClusterProvider.cs#L146
The type 'MemberNotNullAttribute' in '/home/runner/work/couchbase-net-client/couchbase-net-client/src/Couchbase.Extensions.DependencyInjection/../Couchbase/NullableAttributes.cs' conflicts with the imported type 'MemberNotNullAttribute' in 'Couchbase.NetClient, Version=3.9.1.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in '/home/runner/work/couchbase-net-client/couchbase-net-client/src/Couchbase.Extensions.DependencyInjection/../Couchbase/NullableAttributes.cs'.
|
|
Build and Unit Tests (ubuntu-24.04-arm):
tests/Couchbase.UnitTests/Core/IO/Operations/OperationBuilderVBucketIdTests.cs#L111
Null should not be used for type parameter 'vbucketId' of type 'short'. Use a non-null value, or convert the parameter to a nullable type. (https://xunit.net/xunit.analyzers/rules/xUnit1012)
|
|
Build and Unit Tests (ubuntu-24.04-arm):
tests/Couchbase.Extensions.OpenTelemetry.IntegrationTests/OtelClusterFixture.cs#L34
'CouchbaseMeterInstrumentationOptions.ExcludeLegacyMetrics' is obsolete: 'Use DropLegacyRedundantCounters instead.'
|
|
Build and Unit Tests (ubuntu-24.04-arm):
tests/Couchbase.Extensions.OpenTelemetry.IntegrationTests/OtelClusterFixture.cs#L34
'CouchbaseMeterInstrumentationOptions.ExcludeLegacyMetrics' is obsolete: 'Use DropLegacyRedundantCounters instead.'
|
|
Build and Unit Tests (ubuntu-24.04-arm):
src/Couchbase.Extensions.DependencyInjection/Internal/ClusterProvider.cs#L146
The type 'MemberNotNullAttribute' in '/home/runner/work/couchbase-net-client/couchbase-net-client/src/Couchbase.Extensions.DependencyInjection/../Couchbase/NullableAttributes.cs' conflicts with the imported type 'MemberNotNullAttribute' in 'Couchbase.NetClient, Version=3.9.1.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in '/home/runner/work/couchbase-net-client/couchbase-net-client/src/Couchbase.Extensions.DependencyInjection/../Couchbase/NullableAttributes.cs'.
|
|
Build and Unit Tests (ubuntu-24.04-arm):
tests/Couchbase.UnitTests/Core/IO/Operations/OperationBuilderVBucketIdTests.cs#L111
Null should not be used for type parameter 'vbucketId' of type 'short'. Use a non-null value, or convert the parameter to a nullable type. (https://xunit.net/xunit.analyzers/rules/xUnit1012)
|
|
Build and Unit Tests (ubuntu-24.04-arm):
src/Couchbase.Extensions.DependencyInjection/Internal/ClusterProvider.cs#L146
The type 'MemberNotNullAttribute' in '/home/runner/work/couchbase-net-client/couchbase-net-client/src/Couchbase.Extensions.DependencyInjection/../Couchbase/NullableAttributes.cs' conflicts with the imported type 'MemberNotNullAttribute' in 'Couchbase.NetClient, Version=3.9.1.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in '/home/runner/work/couchbase-net-client/couchbase-net-client/src/Couchbase.Extensions.DependencyInjection/../Couchbase/NullableAttributes.cs'.
|
|
Build and Unit Tests (ubuntu-24.04-arm):
tests/Couchbase.UnitTests/Core/IO/Operations/OperationBuilderVBucketIdTests.cs#L111
Null should not be used for type parameter 'vbucketId' of type 'short'. Use a non-null value, or convert the parameter to a nullable type. (https://xunit.net/xunit.analyzers/rules/xUnit1012)
|
|
Build and Unit Tests (ubuntu-24.04)
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-dotnet@v4, actions/upload-artifact@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Build and Unit Tests (ubuntu-24.04):
src/Couchbase.Extensions.DependencyInjection/Internal/ClusterProvider.cs#L146
The type 'MemberNotNullAttribute' in '/home/runner/work/couchbase-net-client/couchbase-net-client/src/Couchbase.Extensions.DependencyInjection/../Couchbase/NullableAttributes.cs' conflicts with the imported type 'MemberNotNullAttribute' in 'Couchbase.NetClient, Version=3.9.1.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in '/home/runner/work/couchbase-net-client/couchbase-net-client/src/Couchbase.Extensions.DependencyInjection/../Couchbase/NullableAttributes.cs'.
|
|
Build and Unit Tests (ubuntu-24.04):
tests/Couchbase.UnitTests/Core/IO/Operations/OperationBuilderVBucketIdTests.cs#L111
Null should not be used for type parameter 'vbucketId' of type 'short'. Use a non-null value, or convert the parameter to a nullable type. (https://xunit.net/xunit.analyzers/rules/xUnit1012)
|
|
Build and Unit Tests (ubuntu-24.04):
tests/Couchbase.Extensions.OpenTelemetry.IntegrationTests/OtelClusterFixture.cs#L34
'CouchbaseMeterInstrumentationOptions.ExcludeLegacyMetrics' is obsolete: 'Use DropLegacyRedundantCounters instead.'
|
|
Build and Unit Tests (ubuntu-24.04):
src/Couchbase.Extensions.DependencyInjection/Internal/ClusterProvider.cs#L146
The type 'MemberNotNullAttribute' in '/home/runner/work/couchbase-net-client/couchbase-net-client/src/Couchbase.Extensions.DependencyInjection/../Couchbase/NullableAttributes.cs' conflicts with the imported type 'MemberNotNullAttribute' in 'Couchbase.NetClient, Version=3.9.1.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in '/home/runner/work/couchbase-net-client/couchbase-net-client/src/Couchbase.Extensions.DependencyInjection/../Couchbase/NullableAttributes.cs'.
|
|
Build and Unit Tests (ubuntu-24.04):
tests/Couchbase.UnitTests/Core/IO/Operations/OperationBuilderVBucketIdTests.cs#L111
Null should not be used for type parameter 'vbucketId' of type 'short'. Use a non-null value, or convert the parameter to a nullable type. (https://xunit.net/xunit.analyzers/rules/xUnit1012)
|
|
Build and Unit Tests (ubuntu-24.04):
tests/Couchbase.Extensions.OpenTelemetry.IntegrationTests/OtelClusterFixture.cs#L34
'CouchbaseMeterInstrumentationOptions.ExcludeLegacyMetrics' is obsolete: 'Use DropLegacyRedundantCounters instead.'
|
|
Build and Unit Tests (ubuntu-24.04):
src/Couchbase.Extensions.DependencyInjection/Internal/ClusterProvider.cs#L146
The type 'MemberNotNullAttribute' in '/home/runner/work/couchbase-net-client/couchbase-net-client/src/Couchbase.Extensions.DependencyInjection/../Couchbase/NullableAttributes.cs' conflicts with the imported type 'MemberNotNullAttribute' in 'Couchbase.NetClient, Version=3.9.1.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in '/home/runner/work/couchbase-net-client/couchbase-net-client/src/Couchbase.Extensions.DependencyInjection/../Couchbase/NullableAttributes.cs'.
|
|
Build and Unit Tests (ubuntu-24.04):
tests/Couchbase.UnitTests/Core/IO/Operations/OperationBuilderVBucketIdTests.cs#L111
Null should not be used for type parameter 'vbucketId' of type 'short'. Use a non-null value, or convert the parameter to a nullable type. (https://xunit.net/xunit.analyzers/rules/xUnit1012)
|
|
Build and Unit Tests (ubuntu-24.04):
tests/Couchbase.Extensions.OpenTelemetry.IntegrationTests/OtelClusterFixture.cs#L34
'CouchbaseMeterInstrumentationOptions.ExcludeLegacyMetrics' is obsolete: 'Use DropLegacyRedundantCounters instead.'
|
|
Build and Unit Tests (ubuntu-24.04):
src/Couchbase.Extensions.DependencyInjection/Internal/ClusterProvider.cs#L146
The type 'MemberNotNullAttribute' in '/home/runner/work/couchbase-net-client/couchbase-net-client/src/Couchbase.Extensions.DependencyInjection/../Couchbase/NullableAttributes.cs' conflicts with the imported type 'MemberNotNullAttribute' in 'Couchbase.NetClient, Version=3.9.1.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in '/home/runner/work/couchbase-net-client/couchbase-net-client/src/Couchbase.Extensions.DependencyInjection/../Couchbase/NullableAttributes.cs'.
|
|
Build and Unit Tests (windows-latest)
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-dotnet@v4, actions/upload-artifact@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Build and Unit Tests (windows-latest):
tests/Couchbase.UnitTests/Core/IO/Operations/OperationBuilderVBucketIdTests.cs#L111
Null should not be used for type parameter 'vbucketId' of type 'short'. Use a non-null value, or convert the parameter to a nullable type. (https://xunit.net/xunit.analyzers/rules/xUnit1012)
|
|
Build and Unit Tests (windows-latest):
tests/Couchbase.UnitTests/Core/IO/Serializers/DefaultSerializerTests.cs#L278
Test methods should not use blocking task operations, as they can cause deadlocks. Use an async test method and await instead. (https://xunit.net/xunit.analyzers/rules/xUnit1031)
|
|
Build and Unit Tests (windows-latest):
tests/Couchbase.UnitTests/Core/IO/Serializers/SystemTextJson/SystemTextJsonSerializerTests.cs#L304
Test methods should not use blocking task operations, as they can cause deadlocks. Use an async test method and await instead. (https://xunit.net/xunit.analyzers/rules/xUnit1031)
|
|
Build and Unit Tests (windows-latest):
src/Couchbase.Extensions.DependencyInjection/Internal/ClusterProvider.cs#L146
The type 'MemberNotNullAttribute' in 'D:\a\couchbase-net-client\couchbase-net-client\src\Couchbase.Extensions.DependencyInjection\../Couchbase/NullableAttributes.cs' conflicts with the imported type 'MemberNotNullAttribute' in 'Couchbase.NetClient, Version=3.9.1.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in 'D:\a\couchbase-net-client\couchbase-net-client\src\Couchbase.Extensions.DependencyInjection\../Couchbase/NullableAttributes.cs'.
|
|
Build and Unit Tests (windows-latest):
tests/Couchbase.Test.Common/Utils/LazyServiceShimFactory.cs#L17
Possible null reference argument for parameter 'value' in 'IReturnsResult<IServiceProvider> IReturns<IServiceProvider, object>.Returns(object value)'.
|
|
Build and Unit Tests (windows-latest):
tests/Couchbase.Test.Common/Fixtures/ClusterFixture.cs#L113
Dereference of a possibly null reference.
|
|
Build and Unit Tests (windows-latest):
tests/Couchbase.Test.Common/Fixtures/ClusterFixture.cs#L107
Dereference of a possibly null reference.
|
|
Build and Unit Tests (windows-latest):
tests/Couchbase.Test.Common/Fixtures/ClusterFixture.cs#L56
Dereference of a possibly null reference.
|
|
Build and Unit Tests (windows-latest):
tests/Couchbase.Test.Common/Utils/TaskAsyncEnumerableExtensions.cs#L33
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
|
|
Build and Unit Tests (windows-latest):
src/Couchbase.Extensions.DependencyInjection/Internal/ClusterProvider.cs#L146
The type 'MemberNotNullAttribute' in 'D:\a\couchbase-net-client\couchbase-net-client\src\Couchbase.Extensions.DependencyInjection\../Couchbase/NullableAttributes.cs' conflicts with the imported type 'MemberNotNullAttribute' in 'Couchbase.NetClient, Version=3.9.1.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in 'D:\a\couchbase-net-client\couchbase-net-client\src\Couchbase.Extensions.DependencyInjection\../Couchbase/NullableAttributes.cs'.
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
unit-test-results-macos-latest
|
652 KB |
sha256:dcccefb8f21a90e260697a2bed42f13cf50e3fe21426afbdabedd91b9c564613
|
|
|
unit-test-results-ubuntu-24.04
|
651 KB |
sha256:733dc587cbf51c0e550e9abe12e5511c30be6eaf75600e2e7f13fa44c22ccc94
|
|
|
unit-test-results-ubuntu-24.04-arm
|
652 KB |
sha256:fb7538bbcfadec51d090df86ad40b9ff9a067fb6cd7bcdcfc15c96d97c0de661
|
|
|
unit-test-results-windows-latest
|
653 KB |
sha256:28354a8ba2582a0fa0ca21f57f6666be7b56bab10a0cf291b695ead44ac2bedd
|
|