Skip to content

Commit bd9e583

Browse files
committed
NCBC-4132: Fix build command
Motivation ---------- The GHA build command was wrongly passing /p:TargetFrameworkVersion=v4.8. Changes ------- Build only with NET48 by specifying the build target, but not the SDK version. Change-Id: I8147d5e09e33aed0209251f482d426353c08981f Reviewed-on: https://review.couchbase.org/c/couchbase-net-client/+/239454 Tested-by: Emilien Bevierre <emilien.bevierre@couchbase.com> Reviewed-by: Emilien Bevierre <emilien.bevierre@couchbase.com>
1 parent bb97069 commit bd9e583

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

.github/workflows/build-and-test-net48.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
run: nuget restore couchbase-net-client.sln
2727

2828
- name: Build (Release)
29-
run: msbuild couchbase-net-client.sln /p:Configuration=Release /p:TargetFrameworkVersion=v4.8 /m
29+
run: msbuild couchbase-net-client.sln /p:Configuration=Release /p:TargetFramework=net48 /m
3030

3131
- name: Setup VSTest
3232
uses: darenm/Setup-VSTest@v1.3

0 commit comments

Comments
 (0)