GOCBC-1817: Update eventing tests to take into account 8.0.1 error changes

* State transitions to the existing state now fail instead of succeeding, as the pre-8.0 behavior has been restored.
* If the function does not exist for a state transition, the error returned is now ERR_APP_NOT_FOUND instead of ERR_APP_NOT_FOUND_TS, which appears like a regression. We should skip this test until this is fixed or we have confirmation that this is the intended behavior.

And one change that had been made before the 8.0 release:
* The bug where the source and metadata keyspaces were allowed to be the same has been fixed. However, the error returned is now ERR_INVALID_REQUEST

Change-Id: I97d2a7030783f2e6d48c1b5e435b55232e6d9b4e
Reviewed-on: https://review.couchbase.org/c/gocb/+/244579
Reviewed-by: Charles Dixon <chvckd@gmail.com>
Tested-by: Build Bot <build@couchbase.com>

Author: DemetrisChr

cluster_eventingmgr_test.go

@@ -200,6 +200,7 @@ func (suite *IntegrationTestSuite) TestEventingManagerUnknownBucket() {
 func (suite *IntegrationTestSuite) runEventingManagerUnknownFunctionTest(scope *Scope) {
 	suite.skipIfUnsupported(CollectionsFeature)
 	suite.skipIfUnsupported(EventingFunctionManagerFeature)
+	suite.skipIfSupported(EventingFunctionManagerMB71748Feature) // Remove once MB-71748 is fixed
 
 	var mgr eventingManager
 	if scope == nil {
@@ -383,7 +384,6 @@ func (suite *IntegrationTestSuite) TestEventingManagerCollectionNotFound() {
 func (suite *IntegrationTestSuite) runEventingManagerSameSourceAndMetaKeyspaceTest(scope *Scope) {
 	suite.skipIfUnsupported(CollectionsFeature)
 	suite.skipIfUnsupported(EventingFunctionManagerFeature)
-	suite.skipIfUnsupported(EventingFunctionManagerMB68025Feature)
 
 	var mgr eventingManager
 	if scope == nil {
@@ -421,9 +421,17 @@ func (suite *IntegrationTestSuite) runEventingManagerSameSourceAndMetaKeyspaceTe
 
 	success := suite.tryUntil(time.Now().Add(2*time.Second), 100*time.Millisecond, func() bool {
 		err := mgr.UpsertFunction(expectedFn, nil)
-		if !errors.Is(err, ErrEventingFunctionIdenticalKeyspace) {
-			suite.T().Logf("Expected ResumeFunction to fail with identical keyspace but was %v", err)
-			return false
+		if globalCluster.SupportsFeature(EventingFunctionManagerMB68025Feature) {
+			// After 8.0 eventing responds with ERR_INVALID_REQUEST
+			if err == nil {
+				suite.T().Logf("Expected ResumeFunction to fail")
+				return false
+			}
+		} else {
+			if !errors.Is(err, ErrEventingFunctionIdenticalKeyspace) {
+				suite.T().Logf("Expected ResumeFunction to fail with identical keyspace but was %v", err)
+				return false
+			}
 		}
 
 		return true
@@ -644,22 +652,15 @@ func (suite *IntegrationTestSuite) runEventingManagerPausesAndResumesTest(scope
 
 	err = mgr.PauseFunction(fnName, nil)
 	if globalCluster.SupportsFeature(EventingFunctionManagerMB67773Feature) {
+		suite.Assert().Error(err)
+	} else {
 		if !errors.Is(err, ErrEventingFunctionNotBootstrapped) {
 			suite.T().Fatalf("Expected UndeployFunction to fail with not bootstrapped but was %v", err)
 		}
-	} else {
-		suite.Assert().Error(err)
 	}
 
 	err = mgr.ResumeFunction(fnName, nil)
 	if globalCluster.SupportsFeature(EventingFunctionManagerMB67773Feature) {
-		if !errors.Is(err, ErrEventingFunctionNotDeployed) {
-			suite.T().Fatalf("Expected UndeployFunction to fail with not deployed but was %v", err)
-		}
-
-		err = mgr.DeployFunction(fnName, nil)
-		suite.Require().Nil(err, err)
-	} else {
 		suite.Require().NoError(err)
 
 		success = suite.tryUntil(time.Now().Add(60*time.Second), 500*time.Millisecond, func() bool {
@@ -679,6 +680,13 @@ func (suite *IntegrationTestSuite) runEventingManagerPausesAndResumesTest(scope
 			return false
 		})
 		suite.Require().True(success, "FunctionsStatus never reported function resumed")
+	} else {
+		if !errors.Is(err, ErrEventingFunctionNotDeployed) {
+			suite.T().Fatalf("Expected UndeployFunction to fail with not deployed but was %v", err)
+		}
+
+		err = mgr.DeployFunction(fnName, nil)
+		suite.Require().Nil(err, err)
 	}
 
 	actualFn, err = mgr.GetFunction(fnName, nil)

testcluster_test.go

@@ -33,6 +33,7 @@ var (
 	srvVer762       = NodeVersion{7, 6, 2, 0, 0, "", false}
 	srvVer764       = NodeVersion{7, 6, 4, 0, 0, "", false}
 	srvVer800       = NodeVersion{8, 0, 0, 0, 0, "", false}
+	srvVer801       = NodeVersion{8, 0, 1, 0, 0, "", false}
 	mockVer156      = NodeVersion{1, 5, 6, 0, 0, "", true}
 	mockVer1513     = NodeVersion{1, 5, 13, 0, 0, "", true}
 	mockVer1515     = NodeVersion{1, 5, 15, 0, 0, "", true}
@@ -120,6 +121,7 @@ var (
 	EventingFunctionManagerResourceNotFoundAtDeploy         = FeatureCode("eventingmanagementcollectionnotfoundatdeploy")
 	EventingFunctionManagerMB68025Feature                   = FeatureCode("eventingmanagementmb68025")
 	EventingFunctionManagerMB67773Feature                   = FeatureCode("eventingmanagementmb67773")
+	EventingFunctionManagerMB71748Feature                   = FeatureCode("eventingmanagementmb71748")
 )
 
 type TestFeatureFlag struct {
@@ -443,15 +445,17 @@ func (c *testCluster) SupportsFeature(feature FeatureCode) bool {
 		case ClusterLabelsFeature:
 			supported = !c.Version.Lower(srvVer764) && !c.Version.Equal(protostellarVer)
 		case EventingFunctionManagerAllowsSameStateTransitionFeature:
-			supported = !c.Version.Lower(srvVer800)
+			supported = c.Version.Equal(srvVer800)
 		case EventingFunctionManagerMB68025Feature:
-			supported = !c.Version.Equal(srvVer800)
+			supported = !c.Version.Lower(srvVer800)
 		case EventingFunctionManagerResourceNotFoundAtDeploy:
 			supported = !c.Version.Lower(srvVer800)
 		case EventingFunctionManagerMB67773Feature:
-			supported = !c.Version.Equal(srvVer800)
+			supported = !c.Version.Lower(srvVer800)
 		case UserManagerGroupRolesFeature:
 			supported = !c.Version.Lower(srvVer700)
+		case EventingFunctionManagerMB71748Feature:
+			supported = !c.Version.Lower(srvVer801)
 		}
 	}