MB-69779: Remove checked_snprintf

Code refactored to use the modern fmtlib

Change-Id: I0f6b1487dad28bdf20bbc9039268527fe751df3c
Reviewed-on: https://review.couchbase.org/c/platform/+/237506
Reviewed-by: Mohammad Zaeem <mohammad.zaeem@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

Author: trondn

CMakeLists.txt

@@ -221,7 +221,6 @@ LIST(APPEND PLATFORM_FILES
   src/byte_buffer_dump.cc
   src/cb_arena_malloc.cc
   src/cb_time.cc
-  src/checked_snprintf.cc
   src/command_line_options_parser.cc
   src/crc32c.cc
   src/crc32c_private.h
@@ -257,7 +256,6 @@ LIST(APPEND PLATFORM_FILES
   include/platform/byte_literals.h
   include/platform/cb_allocator.h
   include/platform/cb_malloc.h
-  include/platform/checked_snprintf.h
   include/platform/command_line_options_parser.h
   include/platform/corestore.h
   include/platform/crc32c.h

include/platform/checked_snprintf.h

@@ -9,7 +9,6 @@ cb_add_test_executable(platform_unit_tests
                        bitset_test.cc
                        byte_literals_test.cc
                        cb_getopt_test.cc
-                       checked_snprintf_test.cc
                        command_line_options_parser_test.cc
                        corestore_test.cc
                        corestore_test.h

src/checked_snprintf.cc

@@ -8,79 +8,49 @@
  *   the file licenses/APL2.txt.
  */
 #include <folly/portability/GTest.h>
-
-#include <platform/checked_snprintf.h>
+#include <folly/portability/Stdlib.h>
 #include <platform/sysinfo.h>
 
-char cpu_count_env_var[256];
-
 TEST(GetAvailableCpu, NoVariable) {
     EXPECT_NE(0u, cb::get_available_cpu_count());
 }
 
 TEST(GetAvailableCpu, CorrectVariable_ExactNumber) {
-    checked_snprintf(cpu_count_env_var,
-                     sizeof(cpu_count_env_var),
-                     "COUCHBASE_CPU_COUNT=10000");
-    putenv(cpu_count_env_var);
+    setenv("COUCHBASE_CPU_COUNT", "10000", 1);
     EXPECT_EQ(10000u, cb::get_available_cpu_count());
 }
 
 TEST(GetAvailableCpu, CorrectVariable_LeadingSpace) {
-    checked_snprintf(cpu_count_env_var,
-                     sizeof(cpu_count_env_var),
-                     "COUCHBASE_CPU_COUNT= 9999");
-    putenv(cpu_count_env_var);
+    setenv("COUCHBASE_CPU_COUNT", " 9999", 1);
     EXPECT_EQ(9999u, cb::get_available_cpu_count());
 }
 
 TEST(GetAvailableCpu, CorrectVariable_TrailingSpace) {
-    checked_snprintf(cpu_count_env_var,
-                     sizeof(cpu_count_env_var),
-                     "COUCHBASE_CPU_COUNT=9998 ");
-    putenv(cpu_count_env_var);
+    setenv("COUCHBASE_CPU_COUNT", "9998 ", 1);
     EXPECT_EQ(9998u, cb::get_available_cpu_count());
 }
 
 TEST(GetAvailableCpu, CorrectVariable_LeadingTab) {
-    checked_snprintf(cpu_count_env_var,
-                     sizeof(cpu_count_env_var),
-                     "COUCHBASE_CPU_COUNT=\t9997");
-    putenv(cpu_count_env_var);
+    setenv("COUCHBASE_CPU_COUNT", "\t9997", 1);
     EXPECT_EQ(9997u, cb::get_available_cpu_count());
 }
 
 TEST(GetAvailableCpu, CorrectVariable_TrailigTab) {
-    checked_snprintf(cpu_count_env_var,
-                     sizeof(cpu_count_env_var),
-                     "COUCHBASE_CPU_COUNT=9996\t");
-    putenv(cpu_count_env_var);
+    setenv("COUCHBASE_CPU_COUNT", "9996\t", 1);
     EXPECT_EQ(9996u, cb::get_available_cpu_count());
 }
 
 TEST(GetAvailableCpu, InvalidValue) {
-    checked_snprintf(cpu_count_env_var,
-                     sizeof(cpu_count_env_var),
-                     "COUCHBASE_CPU_COUNT=1a");
-    putenv(cpu_count_env_var);
+    setenv("COUCHBASE_CPU_COUNT", "1a", 1);
     EXPECT_THROW(cb::get_available_cpu_count(), std::logic_error);
 
-    checked_snprintf(cpu_count_env_var,
-                     sizeof(cpu_count_env_var),
-                     "COUCHBASE_CPU_COUNT=1 a");
-    putenv(cpu_count_env_var);
+    setenv("COUCHBASE_CPU_COUNT", "1 a", 1);
     EXPECT_THROW(cb::get_available_cpu_count(), std::logic_error);
 
-    checked_snprintf(cpu_count_env_var,
-                     sizeof(cpu_count_env_var),
-                     "COUCHBASE_CPU_COUNT=a1");
-    putenv(cpu_count_env_var);
+    setenv("COUCHBASE_CPU_COUNT", "a1", 1);
     EXPECT_THROW(cb::get_available_cpu_count(), std::logic_error);
 
-    checked_snprintf(cpu_count_env_var,
-                     sizeof(cpu_count_env_var),
-                     "COUCHBASE_CPU_COUNT=a 1");
-    putenv(cpu_count_env_var);
+    setenv("COUCHBASE_CPU_COUNT", "a 1", 1);
     EXPECT_THROW(cb::get_available_cpu_count(), std::logic_error);
 }