Merge remote-tracking branch 'couchbase/morpheus' to master

* couchbase/morpheus:
  MB-68823: Introduce ArenaMalloc::getCurrentClientArena()
  CBD-6348: [BP] Fix TestRingBufferVector template constructor
  CBD-6348: [BP] Update for C++20 compatibility
  CBD-6348: [BP] Preparing for folly upgrade to v2022.02.14.00
  CBD-6348: [BP] Fix building with fmt 10.1.0
  CBD-6348: [BP] Remove deprecated format_to(memory_buffer) overload
  Revert "MB-68823: Catch alloc/dealloc arena mismatch for NoClientIndex"
  MB-68823: Catch alloc/dealloc arena mismatch for NoClientIndex
  MB-68823: Allow to toggle ArenaMalloc debug checks dynamically

Change-Id: I42e06fa071c7300aa183664012812772ca26cee7

Author: trondn

src/je_arena_malloc.cc

@@ -36,8 +36,13 @@ namespace cb {
 static bool tcacheEnabled{true};
 
 /// Are additional checks on arena allocations enabled?
-static const bool arenaDebugChecksEnabled{
-        getenv("CB_ARENA_MALLOC_VERIFY_DEALLOC_CLIENT") != nullptr};
+static bool arenaDebugChecksEnabled() {
+#ifndef NDEBUG
+    return getenv("CB_ARENA_MALLOC_VERIFY_DEALLOC_CLIENT") != nullptr;
+#else
+    return false;
+#endif
+}
 
 /**
  * Should Tcache be used?
@@ -57,7 +62,7 @@ static const bool arenaDebugChecksEnabled{
  * we can get a false error.
  */
 static bool isTcacheEnabled(bool requested) {
-    return tcacheEnabled && requested && !arenaDebugChecksEnabled;
+    return tcacheEnabled && requested && !arenaDebugChecksEnabled();
 }
 
 JEArenaMallocBase::CurrentClient::CurrentClient(uint8_t index,
@@ -275,14 +280,14 @@ ArenaMallocClient JEArenaMalloc::registerClient(bool threadCache) {
         auto& client = lockedClients->at(index);
         if (!client.used) {
             assignClientArenas(client.arenas,
-                               arenaDebugChecksEnabled
+                               arenaDebugChecksEnabled()
                                        ? ArenaMode::OnePerDomain
                                        : ArenaMode::SingleArena);
             client.used = true;
 
             ArenaMallocClient newClient{
                     client.arenas, index, isTcacheEnabled(threadCache)};
-            clientRegistered(newClient, arenaDebugChecksEnabled);
+            clientRegistered(newClient, arenaDebugChecksEnabled());
             return newClient;
         }
     }
@@ -429,7 +434,7 @@ template <>
 void JEArenaMalloc::free(void* ptr) {
     if (ptr) {
         auto c = ThreadLocalData::get().getCurrentClient();
-        if (arenaDebugChecksEnabled) {
+        if (arenaDebugChecksEnabled()) {
             verifyMemDeallocatedByCorrectClient(c, ptr, je_sallocx(ptr, 0));
         }
         memDeallocated(c.index, c.domain, ptr);
@@ -447,7 +452,7 @@ template <>
 void JEArenaMalloc::sized_free(void* ptr, size_t size) {
     if (ptr) {
         auto c = ThreadLocalData::get().getCurrentClient();
-        if (arenaDebugChecksEnabled) {
+        if (arenaDebugChecksEnabled()) {
             verifyMemDeallocatedByCorrectClient(c, ptr, size);
         }
         memDeallocated(c.index, c.domain, size);