MB-69449: clang may also need stdc++exp

clang-18.1.3 on Ununtu 24 fails with the same error
as newer versions of g++

Change-Id: I8915300dbbb6747efa9cbe54a244f6d9ac08844b
Reviewed-on: https://review.couchbase.org/c/platform/+/237425
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Mohammad Zaeem <mohammad.zaeem@couchbase.com>

Author: trondn

CMakeLists.txt

@@ -66,43 +66,43 @@ else(WIN32)
     endif()
 endif(WIN32)
 
-# Some versions of GCC needs an explicit link to stdc++exp to get
-# stacktrace support.
+# Some versions of GCC / clang needs an explicit link to stdc++exp
+# to get stacktrace support.
 set(BACKTRACE_EXTRA_LIB "")
-if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
-    cmake_push_check_state(RESET)
+cmake_push_check_state(RESET)
 
-    check_cxx_source_compiles(
-            "#include <stacktrace>
+check_cxx_source_compiles(
+        "#include <stacktrace>
 #include <iostream>
 int main() {
-    std::cout << std::to_string(std::stacktrace::current());
-    return 0;
+std::cout << std::to_string(std::stacktrace::current());
+return 0;
 }
-    "
-            HAVE_LIB_STACKTRACE_WITHOUT_EXTRA_LIB
-    )
+"
+        HAVE_LIB_STACKTRACE_WITHOUT_EXTRA_LIB
+)
 
-    if (NOT HAVE_LIB_STACKTRACE_WITHOUT_EXTRA_LIB)
-        set(CMAKE_REQUIRED_LIBRARIES stdc++exp)
-        check_cxx_source_compiles(
-                "#include <stacktrace>
+if (NOT HAVE_LIB_STACKTRACE_WITHOUT_EXTRA_LIB)
+    set(CMAKE_REQUIRED_LIBRARIES stdc++exp)
+    check_cxx_source_compiles(
+            "#include <stacktrace>
 #include <iostream>
 int main() {
-    std::cout << std::to_string(std::stacktrace::current());
-    return 0;
+std::cout << std::to_string(std::stacktrace::current());
+return 0;
 }
-    "
-                HAVE_LIB_STACKTRACE_WITH_EXTRA_LIB
-        )
-        if (HAVE_LIB_STACKTRACE_WITH_EXTRA_LIB)
-            set(BACKTRACE_EXTRA_LIB "stdc++exp")
-        endif (HAVE_LIB_STACKTRACE_WITH_EXTRA_LIB)
-    endif ()
-
-    cmake_pop_check_state()
+"
+            HAVE_LIB_STACKTRACE_WITH_EXTRA_LIB
+    )
+    if (HAVE_LIB_STACKTRACE_WITH_EXTRA_LIB)
+        set(BACKTRACE_EXTRA_LIB "stdc++exp")
+    else ()
+        add_definitions(-DSTD_STACKTRACE_WONT_WORK=1)
+    endif (HAVE_LIB_STACKTRACE_WITH_EXTRA_LIB)
 endif ()
 
+cmake_pop_check_state()
+
 CONFIGURE_FILE (${CMAKE_CURRENT_SOURCE_DIR}/include/platform/dynamic.in.h
                 ${CMAKE_CURRENT_BINARY_DIR}/include/platform/dynamic.h)
 

src/backtrace.cc

@@ -21,7 +21,11 @@
 #include <execinfo.h> // for backtrace()
 #endif
 
-#if __cpp_lib_stacktrace
+#if defined(__cpp_lib_stacktrace) && !defined(STD_STACKTRACE_WONT_WORK)
+#define HAVE_STD_STACKTRACE_SUPPORT 1
+#endif
+
+#if HAVE_STD_STACKTRACE_SUPPORT
 #include <stacktrace>
 #endif
 
@@ -207,7 +211,7 @@ void cb::backtrace::initialize() {
 
 namespace cb::backtrace {
 
-#if __cpp_lib_stacktrace
+#if HAVE_STD_STACKTRACE_SUPPORT
 [[nodiscard]] std::string current() {
     return std::to_string(std::stacktrace::current());
 }