ING-1496: Return appropriate status when DocNotFound

Author: Westwooo

gateway/dataimpl/server_v1/kvserver.go

@@ -1392,7 +1392,9 @@ func (s *KvServer) GetAllReplicas(in *kv_v1.GetAllReplicasRequest, out kv_v1.KvS
 	}
 
 	if replicaError != nil {
-		if errors.Is(replicaError, memdx.ErrAccessError) {
+		if errors.Is(replicaError, memdx.ErrDocNotFound) {
+			return s.errorHandler.NewDocMissingStatus(out.Context(), replicaError, in.BucketName, in.ScopeName, in.CollectionName, in.Key).Err()
+		} else if errors.Is(replicaError, memdx.ErrAccessError) {
 			return s.errorHandler.NewCollectionNoReadAccessStatus(out.Context(), replicaError, in.BucketName, in.ScopeName, in.CollectionName).Err()
 		}
 

gateway/test/crud_test.go

@@ -4926,18 +4926,9 @@ func (s *GatewayOpsTestSuite) TestGetAllReplicas() {
 		}, grpc.PerRPCCredentials(s.basicRpcCreds))
 		requireRpcSuccess(s.T(), resp, err)
 
-		numResults := 0
-		for {
-			_, err := resp.Recv()
-			if err != nil {
-				break
-			}
-
-			numResults++
-		}
-
-		// This document does not exist on any node so resp.Recv should have immediately errored.
-		require.Zero(s.T(), numResults)
+		_, err = resp.Recv()
+		require.Error(s.T(), err)
+		assertRpcStatus(s.T(), err, codes.NotFound)
 	})
 
 	s.RunCommonErrorCases(func(ctx context.Context, opts *commonErrorTestData) (interface{}, error) {