Apply suggestions from code review

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Author: torcolvin

base/dcp_feed_type.go

@@ -166,8 +166,8 @@ type SGFeedIndexParams struct {
 	DestKey string `json:"destKey,omitempty"`
 }
 
-// cbgtFeedParams returns marshalled cbgt.DCPFeedParams as string. This contains information to for a given information , to be passed as feedparams during cbgt.Manager init.
-func cbgtFeedParams(ctx context.Context, opts ShardedDCPOptions) (string, error) {
+// cbgtFeedParams returns a JSON-encoded SGFeedSourceParams string to be passed as cbgt feed sourceParams.
+// It includes the SG database name, optional scope/collections, and (when opts.EndSeqNos is set) StopAfter/MarkPartitionSeqs for one-shot feeds.
 	feedParams := &SGFeedSourceParams{
 		DbName: opts.DBName,
 		DCPFeedParams: cbgt.DCPFeedParams{

base/dcp_sharded.go

@@ -929,8 +929,7 @@ type sgMgrEventHandlers struct {
 	ctx                    context.Context
 	ctxCancel              context.CancelCauseFunc
 	manager                *cbgt.Manager
-	unregisterFeedCallback func(cbgt.Feed) // callback function for when a feed is unregistered. This occurs when a feed completes for any reason: Stop is requested, a rebalance of partitions, the feed naturally ends when reaching expected seequence numbers.
-}
+	unregisterFeedCallback func(cbgt.Feed) // callback function for when a feed is unregistered. This occurs when a feed completes for any reason: Stop is requested, a rebalance of partitions, or the feed naturally ends when reaching expected sequence numbers.
 
 func (meh *sgMgrEventHandlers) OnRefreshManagerOptions(options map[string]string) {
 	// No-op for SG

db/background_mgr_resync_dcp.go

@@ -638,10 +638,9 @@ func (r *ResyncManagerDCP) GetProcessStatus(status BackgroundManagerStatus, prev
 // doneChan when all vBuckets have completed, which will allow the resync process to finish.
 func (r *ResyncManagerDCP) getUnregisterFeedFunc(ctx context.Context, totalVBuckets uint16) base.CbgtUnregisterFeedCallback {
 	return func(feed cbgt.Feed) {
-		for _, d := range feed.Dests() {
-			d, ok := d.(base.SGDest)
-			if !ok {
-				base.AssertfCtx(ctx, "Expected dest on cbgt.EventHandler.OnUnregisterFeed to be of type SGDest but is of type %T, resync will can complete but checkpoints may not be written", d)
+		for _, dest := range feed.Dests() {
+			if _, ok := dest.(base.SGDest); !ok {
+				base.AssertfCtx(ctx, "Expected dest on cbgt.EventHandler.OnUnregisterFeed to be of type SGDest but is of type %T; resync can complete but checkpoints may not be written", dest)
 			}
 		}
 		f, ok := feed.(cbgt.FeedPartitionCompletion)