Skip to content

Commit 499ede0

Browse files
committed
Fixed testcases parsing errors
- fixed update import filters test payload - fixed update access functions test payload Change-Id: I98cc8b43df4497503f18b9372ab48a6e6f92138d Reviewed-on: https://review.couchbase.org/c/TAF/+/228020 Reviewed-by: VIPUL BHARDWAJ <vipul.bhardwaj@couchbase.com> Tested-by: Build Bot <build@couchbase.com>
1 parent 09e241d commit 499ede0

2 files changed

Lines changed: 32 additions & 7 deletions

File tree

pytests/Capella/RestAPIv4/AppEndpoints/update_access_functions.py

Lines changed: 19 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,8 @@ def test_payload(self):
335335
for v in [
336336
"", None, [], {},
337337
self.generate_random_string(special_characters=False),
338-
self.generate_random_string(500, special_characters=False),
338+
"1" + self.generate_random_string(499, special_characters=False),
339+
"A" + self.generate_random_string(499, special_characters=False)
339340
]:
340341
testcase = dict()
341342
testcase["payload"] = v
@@ -346,17 +347,29 @@ def test_payload(self):
346347
"hint": "Please review your request and ensure that all "
347348
"required parameters are correctly provided.",
348349
"httpStatusCode": 400,
349-
"message": "bad request: 1 errors:\ncollection \"_default\" "
350-
"sync function error: invalid javascript syntax: "
351-
"ReferenceError: '{}' is not defined".format(v)}
350+
"message": "No request body given"
351+
}
352352
testcase["expected_status_code"] = 400
353-
if v in ['', {}, [], None]:
353+
if isinstance(v, str) and len(v) > 1 and v[0].isalpha() :
354+
testcase["expected_error"] = {
355+
"code": 400,
356+
"hint": "Please review your request and ensure that all "
357+
"required parameters are correctly provided.",
358+
"httpStatusCode": 400,
359+
"message": "bad request: 1 errors:\ncollection \"_default\" "
360+
"sync function error: invalid javascript syntax: "
361+
"ReferenceError: '{}' is not defined".format(v)
362+
}
363+
elif isinstance(v, str) and len(v) > 1 and v[0].isdigit() :
354364
testcase["expected_error"] = {
355365
"code": 400,
356366
"hint": "Please review your request and ensure that all "
357367
"required parameters are correctly provided.",
358368
"httpStatusCode": 400,
359-
"message": "No request body given"
369+
"message": "bad request: 1 errors:\ncollection \"_default\" "
370+
"sync function error: invalid javascript syntax: "
371+
"(anonymous): Line 1:2 Unexpected token "
372+
"ILLEGAL (and 1 more errors)"
360373
}
361374
testcases.append(testcase)
362375

pytests/Capella/RestAPIv4/AppEndpoints/update_import_filters.py

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,8 @@ def test_payload(self):
359359
testcases = list()
360360
for v in [
361361
"" "abc", self.generate_random_string(special_characters=False),
362-
self.generate_random_string(500, special_characters=False),
362+
"1" + self.generate_random_string(499, special_characters=False),
363+
"A" + self.generate_random_string(499, special_characters=False)
363364
]:
364365
testcase = dict()
365366
testcase["payload"] = v
@@ -376,6 +377,17 @@ def test_payload(self):
376377
"defined".format(v)
377378
}
378379
testcase["expected_status_code"] = 400
380+
if isinstance(v, str) and len(v) > 1 and v[0].isdigit():
381+
testcase["expected_error"] = {
382+
"code": 400,
383+
"hint": "Please review your request and ensure that all "
384+
"required parameters are correctly provided.",
385+
"httpStatusCode": 400,
386+
"message": "bad request: 1 errors:\ncollection \"_default\" "
387+
"import filter error: invalid javascript syntax: "
388+
"(anonymous): Line 1:2 Unexpected token "
389+
"ILLEGAL (and 1 more errors)"
390+
}
379391
testcases.append(testcase)
380392

381393
failures = list()

0 commit comments

Comments
 (0)