Skip to content

Commit 53d9a42

Browse files
committed
code review feedback
1 parent 58717b1 commit 53d9a42

6 files changed

Lines changed: 5 additions & 12 deletions

File tree

docs/getting-started.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,7 @@ var cluster = Cluster.Create(
6565
```
6666

6767
> [!NOTE]
68-
> The client certificate must contain a private key. When using mTLS, no HTTP `Authorization` header
69-
> is sent — authentication is handled entirely during the TLS handshake.
68+
> The client certificate must contain a private key.
7069
7170
#### Updating Credentials
7271

src/Couchbase.Analytics/Cluster.cs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -125,10 +125,6 @@ public static Cluster Create(ICredential credential, ClusterOptions clusterOptio
125125
return new Cluster(credential, clusterOptions);
126126
}
127127

128-
// ── Binary-compatible forwarding overloads ──────────────────────────
129-
// These preserve the exact method signatures from before the ICredential
130-
// widening, so that existing compiled code continues to resolve correctly
131-
// at runtime without recompilation.
132128

133129
/// <summary>
134130
/// Creates a cluster with a connection string, username/password credential, and an options builder.

src/Couchbase.Analytics/HTTP/CertificateCredential.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ public static CertificateCredential FromPem(string certPath, string keyPath) =>
9696
/// </summary>
9797
private bool PrintMembers(StringBuilder builder)
9898
{
99-
builder.Append($"Subject = {Certificate.Subject}, Thumbprint = {Certificate.Thumbprint}");
99+
builder.Append($"{nameof(Certificate.Subject)} = {Certificate.Subject}, {nameof(Certificate.Thumbprint)} = {Certificate.Thumbprint}");
100100
return true;
101101
}
102102
}

src/Couchbase.Analytics/HTTP/Credential.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public static Credential Create(string username, string password)
5252
/// </summary>
5353
protected virtual bool PrintMembers(System.Text.StringBuilder builder)
5454
{
55-
builder.Append($"Username = {Username}");
55+
builder.Append($"{nameof(Username)} = {Username}");
5656
return true;
5757
}
5858
}

src/Couchbase.Analytics/HTTP/JwtCredential.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public static JwtCredential Create(string token)
4949
/// </summary>
5050
private bool PrintMembers(System.Text.StringBuilder builder)
5151
{
52-
builder.Append($"Token = <{Token.Length} chars>");
52+
builder.Append($"{nameof(Token)} = <{Token.Length} chars>");
5353
return true;
5454
}
5555
}

src/Couchbase.Analytics/Internal/HTTP/CouchbaseHttpClientFactory.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -192,9 +192,7 @@ public HttpClient Create()
192192
/// The old handler is disposed after a grace period via <see cref="DisposeAfterDelayAsync"/>.
193193
/// This follows the same pattern as <c>IHttpClientFactory</c> in ASP.NET Core, which defers
194194
/// handler disposal to allow request draining. The grace period is generous (1 minute) to
195-
/// accommodate the maximum query timeout. This avoids the <see cref="ObjectDisposedException"/>
196-
/// race that would occur with immediate disposal (a known issue in the operational SDK's
197-
/// <c>CouchbaseHttpClientFactory.RecreateHandler</c>).
195+
/// accommodate the maximum query timeout.
198196
/// </para>
199197
/// </remarks>
200198
/// <param name="newCredential">The new credential that triggered the rebuild.</param>

0 commit comments

Comments
 (0)