NCO-56 fix warnings in build

* Added .editorconfig - can extend this as needed
* Ran dotnet format, fixing whietspace, unused usings, etc...
* Fixed other warnings as well
* Removed redundant package references (since we are .NET 10 only)
* Unused import in proto files remain until we go to the source
  of the files and fix them there

Author: davidkelly

fit/Couchbase.Analytics.Performer/Couchbase.Analytics.Performer.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
     <PropertyGroup>
         <OutputType>Exe</OutputType>

fit/Couchbase.Analytics.Performer/Internal/Connections/ClusterConnection.cs

@@ -40,4 +40,4 @@ public void Dispose()
             _cluster?.Dispose();
         }
     }
-}
+}

fit/Couchbase.Analytics.Performer/Internal/Exceptions/GrpcUnimplementedException.cs

@@ -1,3 +1,3 @@
 namespace Couchbase.Analytics.Performer.Internal.Exceptions;
 
-public class GrpcUnimplementedException : Exception;
+public class GrpcUnimplementedException : Exception;

fit/Couchbase.Analytics.Performer/Internal/Logging/LoggingUtils.cs

@@ -50,20 +50,20 @@ public static LogEventLevel ParseLogLevelOrDefault(string? value, LogEventLevel
             return serilogLevel;
         }
 
-        if (Enum.TryParse<Microsoft.Extensions.Logging.LogLevel>(value, true, out var msLevel))
+        if (Enum.TryParse<LogLevel>(value, true, out var msLevel))
         {
             return msLevel switch
             {
-                Microsoft.Extensions.Logging.LogLevel.Trace => LogEventLevel.Verbose,
-                Microsoft.Extensions.Logging.LogLevel.Debug => LogEventLevel.Debug,
-                Microsoft.Extensions.Logging.LogLevel.Information => LogEventLevel.Information,
-                Microsoft.Extensions.Logging.LogLevel.Warning => LogEventLevel.Warning,
-                Microsoft.Extensions.Logging.LogLevel.Error => LogEventLevel.Error,
-                Microsoft.Extensions.Logging.LogLevel.Critical => LogEventLevel.Fatal,
+                LogLevel.Trace => LogEventLevel.Verbose,
+                LogLevel.Debug => LogEventLevel.Debug,
+                LogLevel.Information => LogEventLevel.Information,
+                LogLevel.Warning => LogEventLevel.Warning,
+                LogLevel.Error => LogEventLevel.Error,
+                LogLevel.Critical => LogEventLevel.Fatal,
                 _ => defaultLevel
             };
         }
 
         return defaultLevel;
     }
-}
+}

fit/Couchbase.Analytics.Performer/Internal/Modes/Mode.cs

@@ -4,4 +4,4 @@ public enum Mode
 {
     PushBasedStreaming,
     Buffered,
-}
+}

fit/Couchbase.Analytics.Performer/Internal/Services/AnalyticsPerformerCrossService.cs

@@ -5,8 +5,8 @@
 using Couchbase.Analytics.Performer.Internal.Utils;
 using Couchbase.AnalyticsClient.Options;
 using Couchbase.AnalyticsClient.Results;
-using Couchbase.Grpc.Protocol.Columnar;
 using Couchbase.Core.Utils;
+using Couchbase.Grpc.Protocol.Columnar;
 using Google.Protobuf.WellKnownTypes;
 using Grpc.Core;
 using Error = Couchbase.Grpc.Protocol.Columnar.Error;
@@ -64,7 +64,8 @@ public override Task<ExecuteQueryResponse> ExecuteQuery(ExecuteQueryRequest requ
 
         _ongoingQueries.TryAdd(queryHandle, performerQuery);
 
-        var response = new ExecuteQueryResponse(){
+        var response = new ExecuteQueryResponse()
+        {
             QueryHandle = queryHandle,
             Metadata = new ResponseMetadata
             {
@@ -179,7 +180,7 @@ public override Task<EmptyResultOrFailureResponse> QueryCancel(QueryCancelReques
             performerQuery.CancellationTokenSource?.Cancel();
             response.EmptySuccess = true;
         }
-        catch (System.Exception ex)
+        catch (Exception)
         {
             //TODO: Map exceptions?
             response.Error = new Error();
@@ -220,7 +221,8 @@ public override async Task<QueryResultMetadataResponse> QueryMetadata(QueryMetad
                 ElapsedNanos = (long)stopwatch.Elapsed.TotalNanoseconds,
                 Initiated = initiated
             };
-        } catch (Exception ex)
+        }
+        catch (Exception ex)
         {
             response = new QueryResultMetadataResponse();
             response.Failure = ex.ToProtoError();
@@ -266,4 +268,4 @@ public override Task<EmptyResultOrFailureResponse> CloseAllQueryResults(CloseAll
 
         return Task.FromResult(response);
     }
-}
+}

fit/Couchbase.Analytics.Performer/Internal/Services/AnalyticsPerformerService.cs

@@ -4,16 +4,16 @@
 using Couchbase.Analytics.Performer.Internal.Modes;
 using Couchbase.Analytics.Performer.Internal.Utils;
 using Couchbase.AnalyticsClient;
+using Couchbase.Core.Utils;
 using Couchbase.Grpc.Protocol.Columnar;
 using Couchbase.Grpc.Protocol.Shared;
-using Couchbase.Core.Utils;
 using Google.Protobuf.WellKnownTypes;
 using Grpc.Core;
 using Exception = System.Exception;
 
 namespace Couchbase.Analytics.Performer.Internal.Services;
 
-internal class AnalyticsPerformerService: ColumnarService.ColumnarServiceBase
+internal class AnalyticsPerformerService : ColumnarService.ColumnarServiceBase
 {
     public AnalyticsPerformerService(ConcurrentDictionary<string, ClusterConnection> clusters)
     {
@@ -51,19 +51,19 @@ public override Task<EmptyResultOrFailureResponse> ClusterNewInstance(ClusterNew
                     return new(request, cluster);
                 });
 
-           /* context.GetHttpContext().Response.OnCompleted(() =>
-            {
-                foreach (var tunable in request.Tunables)
-                {
-                    Environment.SetEnvironmentVariable(tunable.Key, null);
-                }
+            /* context.GetHttpContext().Response.OnCompleted(() =>
+             {
+                 foreach (var tunable in request.Tunables)
+                 {
+                     Environment.SetEnvironmentVariable(tunable.Key, null);
+                 }
 
-                return Task.CompletedTask;
-            });*/
+                 return Task.CompletedTask;
+             });*/
 
-           Serilog.Log.Information(
-                "Created or using new cluster instance in {Seconds}: {ConnectionString}",
-                stopWatch.Elapsed, request.ConnectionString);
+            Serilog.Log.Information(
+                 "Created or using new cluster instance in {Seconds}: {ConnectionString}",
+                 stopWatch.Elapsed, request.ConnectionString);
 
             response.GetResponseMetaData(stopWatch, initiated);
         }
@@ -232,7 +232,7 @@ public override Task<EmptyResultOrFailureResponse> CloseAllClusters(CloseAllColu
 
     public override Task<EchoResponse> Echo(EchoRequest request, ServerCallContext context)
     {
-        Serilog.Log.Information("Calling Echo - {TestName} | {Message}",request.TestName, request.Message);
+        Serilog.Log.Information("Calling Echo - {TestName} | {Message}", request.TestName, request.Message);
         return Task.FromResult(new EchoResponse());
     }
-}
+}

fit/Couchbase.Analytics.Performer/Internal/Utils/ClusterNewInstanceRequestExtensions.cs

@@ -44,7 +44,7 @@ public static ClusterOptions ToSdkQueryOptions(this ClusterNewInstanceRequest re
         return clusterOptions;
     }
 
-    private static TimeoutOptions ToCore(this Couchbase.Grpc.Protocol.Columnar.ClusterNewInstanceRequest.Types.Options.Types.TimeoutOptions? protoTimeout)
+    private static TimeoutOptions ToCore(this ClusterNewInstanceRequest.Types.Options.Types.TimeoutOptions? protoTimeout)
     {
         var timeoutOptions = new TimeoutOptions();
         if (protoTimeout is null) return timeoutOptions;
@@ -65,7 +65,7 @@ private static TimeoutOptions ToCore(this Couchbase.Grpc.Protocol.Columnar.Clust
     }
 
     private static SecurityOptions ToCore(
-        this Couchbase.Grpc.Protocol.Columnar.ClusterNewInstanceRequest.Types.Options.Types.SecurityOptions? protoSecurity)
+        this ClusterNewInstanceRequest.Types.Options.Types.SecurityOptions? protoSecurity)
     {
         var securityOptions = new SecurityOptions();
         if (protoSecurity is null) return securityOptions;
@@ -74,7 +74,7 @@ private static SecurityOptions ToCore(
         {
             // what is this?
         }
-        else if(protoSecurity.HasTrustOnlyCapella)
+        else if (protoSecurity.HasTrustOnlyCapella)
         {
             securityOptions = securityOptions.WithTrustOnlyCapella();
         }
@@ -105,4 +105,4 @@ private static SecurityOptions ToCore(
     }
 
 
-}
+}

fit/Couchbase.Analytics.Performer/Internal/Utils/ContentAsExtensions.cs

@@ -8,7 +8,7 @@ namespace Couchbase.Analytics.Performer.Internal.Utils;
 
 public static class ContentAsExtensions
 {
-    public static ContentWas ContentAsToAnalyticsRow(this AnalyticsRow analyticsRow, Couchbase.Grpc.Protocol.Columnar.ContentAs contentAs)
+    public static ContentWas ContentAsToAnalyticsRow(this AnalyticsRow analyticsRow, ContentAs contentAs)
     {
         switch (contentAs.AsCase)
         {
@@ -79,4 +79,4 @@ private static Value ConvertJsonToProtoValue(JsonElement element)
                 return new Value { NullValue = NullValue.NullValue };
         }
     }
-}
+}

fit/Couchbase.Analytics.Performer/Internal/Utils/EmptyResultOrFailureResponseExtensions.cs

@@ -1,5 +1,5 @@
-using Couchbase.Grpc.Protocol.Columnar;
 using Couchbase.Core.Utils;
+using Couchbase.Grpc.Protocol.Columnar;
 using Google.Protobuf.WellKnownTypes;
 
 namespace Couchbase.Analytics.Performer.Internal.Utils;
@@ -28,4 +28,4 @@ public static EmptyResultOrFailureResponse GetResponseMetaData(this EmptyResultO
 
         return emptyResultOrFailureResponse;
     }
-}
+}