Skip to content

Commit edcd51a

Browse files
jeffrymorrisemilienbev
authored andcommitted
NCO-40: Use ResponseHeadersRead for AsStreaming
Motivation ---------- Make streaming queries use ResponseHeadersRead and blocking queries use ResponseContentRead. Modifications ------------- - Switch HttpCompletionOptions for streaming/blocking - Fixup unit tests
1 parent 7b8095f commit edcd51a

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/Couchbase.Analytics/AnalyticsService.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ private async Task<IQueryResult> ExecuteQueryAsync(StringContent content, HttpCl
6464

6565
try
6666
{
67-
var response = await httpClient.SendAsync(request,
68-
HttpCompletionOption.ResponseHeadersRead,
67+
var response = await httpClient.SendAsync(request,
68+
asStreaming ? HttpCompletionOption.ResponseHeadersRead : HttpCompletionOption.ResponseContentRead,
6969
cancellationToken)
7070
.ConfigureAwait(false);
7171

tests/Couchbase.Analytics.FunctionalTests/Internal/AnalyticsServiceTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public async Task Test_Streaming_Query()
4545
var result = await _analytics2Fixture.Cluster.ExecuteQueryAsync(statement,
4646
new QueryOptions() { Timeout = TimeSpan.FromSeconds(10), AsStreaming = true});
4747

48-
await foreach (var row in result)
48+
await foreach (var row in result.ConfigureAwait(false))
4949
{
5050
var value = row.ContentAs<JsonElement>();
5151
_outputHelper.WriteLine(value.ToString());
@@ -62,7 +62,7 @@ public async Task Test_Blocking_Query()
6262
var result = await _analytics2Fixture.Cluster.ExecuteQueryAsync(statement,
6363
new QueryOptions() { Timeout = TimeSpan.FromSeconds(10), AsStreaming = false});
6464

65-
await foreach (var row in result)
65+
await foreach (var row in result.ConfigureAwait(false))
6666
{
6767
var value = row.ContentAs<JsonElement>();
6868
_outputHelper.WriteLine(value.ToString());

0 commit comments

Comments
 (0)