-
Notifications
You must be signed in to change notification settings - Fork 44
[contracts] Make CounterfactualApp an abstract contract #1208
Comments
Is this issue still relevant? Looks like |
I don't think so, but I'll let @snario or @IIIIllllIIIIllllIIIIllllIIIIllllIIIIll confirm |
I found that the pattern isn't implemented in one of the
|
@adklempner But yes, you could argue that we should remove the |
It's actually ambiguous whether or not Also in the original statement of this issue I specifically put that this code: contract X is CounterfactualApp {} Should be a valid app in the framework. Meaning you could install Maybe abstract contract was the wrong word choice; I think I meant just "contract"; as in This is also debatable a bad idea; maybe it shouldn't be possible to inherit defaults here. |
Ah, I see. I do agree with converting To convert,
|
why shouldn't the appState include threshold? |
because to comply with |
Fundamentally the refund app will need to be a I think the general rule of thumb is that if you break the |
It should be possible to create
contract X is CounterfactualApp {}
and have that exist as a real app inside the framework.The text was updated successfully, but these errors were encountered: