Skip to content
This repository has been archived by the owner on Dec 13, 2019. It is now read-only.

[node] Resolution necessarily assumes non-zero payouts #1371

Open
cf19drofxots opened this issue Apr 26, 2019 · 2 comments
Open

[node] Resolution necessarily assumes non-zero payouts #1371

cf19drofxots opened this issue Apr 26, 2019 · 2 comments
Assignees
Labels
🐞 Bug 📦 Machine code related to packages/machine 📦 Node code related to packages/node
Milestone

Comments

@cf19drofxots
Copy link
Member

https://github.com/counterfactual/monorepo/blob/master/packages/node/src/protocol/utils/get-resolution-increments.ts#L43

This line assumes that the resolution of an app is such that all channel participants receive a non-zero payout when the app is being uninstalled and its funds are being withdrawn from the app.

This assumption doesn't necessarily hold if there's at least one channel participant who has not allocated any funds into an app (eg. a unidirectional payment app that is uninstalled immediately after it is installed, meaning no transfers have taken place, resulting in the payout of the recipient of this unidirectional payment app to be 0)

@cf19drofxots cf19drofxots added 📦 Machine code related to packages/machine 📦 Node code related to packages/node 🐞 Bug labels Apr 26, 2019
@ldct ldct changed the title [node, machine] Resolution necessarily assumes non-zero payouts [node] Resolution necessarily assumes non-zero payouts Apr 30, 2019
@snario
Copy link
Contributor

snario commented May 8, 2019

@IIIIllllIIIIllllIIIIllllIIIIllllIIIIll this is very relevant to #1263. Can you comment on if that PR helps address this? If not, @cf19drofxots I'm going to assign to you and put in high priority for Kazooie.

@snario snario added this to the 🐻 Kazooie milestone May 8, 2019
@ldct
Copy link
Member

ldct commented May 8, 2019

#1263 continues to assume a non-zero payout

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 Bug 📦 Machine code related to packages/machine 📦 Node code related to packages/node
Projects
None yet
Development

No branches or pull requests

3 participants