Skip to content
This repository has been archived by the owner on Dec 13, 2019. It is now read-only.

[monorepo] Contract tests fail on second consecutive run, probably b/c of machine tests from first run #669

Open
emansipater opened this issue Feb 5, 2019 · 1 comment

Comments

@emansipater
Copy link
Member

emansipater commented Feb 5, 2019

Most likely this is because the machine uses truffle to build artifacts but the contracts folder uses waffle, and we were previously relying on the assumption that the build output was the same for both (when both were on truffle).

To replicate, run yarn test twice in the monorepo root.

@emansipater emansipater added 📦 Contracts code related to packages/contracts 🐞 Bug labels Feb 5, 2019
@snario
Copy link
Contributor

snario commented Feb 26, 2019

Potential fix: have machine make a second folder to put build artifacts in vs relying on the build folder in contracts. The reason it uses that now is because on the first run it can re-use the compile step from the contracts yarn build command instead of doing another compilation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants