fix: avoid outputting nan for id cache

Author: Josh-Cena

ferry/transform/cache_id.py

@@ -71,7 +71,7 @@ def save_id_cache(tables: dict[str, pd.DataFrame], data_dir: Path):
         .set_index(["building_code", "room"])["location_id"]
         .to_dict()
     )
-    location_to_id = {f"{k[0]} {k[1] or ''}": v for k, v in location_to_id.items()}
+    location_to_id = {f"{k[0]} {'' if pd.isna(k[1]) else k[1]}": v for k, v in location_to_id.items()}
     professor_to_id = (
         tables["professors"].set_index(["name", "email"])["professor_id"].to_dict()
     )

ferry/transform/import_courses.py

@@ -287,7 +287,7 @@ def report_multiple_names(row: pd.DataFrame):
 
     locations["location_id"] = generate_id(
         locations,
-        lambda row: f"{row['code']} {row['room'] or ''}",
+        lambda row: f"{row['code']} {'' if pd.isna(row['room']) else row['room']}",
         data_dir / "id_cache" / "location_id.json",
     )
     location_to_id = locations.set_index(["code", "room"])["location_id"].to_dict()