Differentiate IO exception from not saved file

Author: courtneyeh

validator/api/src/main/java/tech/pegasys/teku/validator/api/GraffitiManager.java

@@ -78,6 +78,10 @@ private Optional<String> updateGraffiti(final BLSPublicKey publicKey, final Stri
 
   public Optional<Bytes32> getGraffiti(final BLSPublicKey publicKey) {
     final Path filePath = graffitiPath.resolve(resolveFileName(publicKey));
+    if (!filePath.toFile().exists()) {
+      return Optional.empty();
+    }
+
     try {
       return Optional.of(GraffitiParser.loadFromFile(filePath)).filter(this::graffitiNotEmpty);
     } catch (GraffitiLoaderException | IllegalArgumentException e) {

validator/api/src/test/java/tech/pegasys/teku/validator/api/GraffitiManagerTest.java

@@ -162,8 +162,7 @@ private void checkStoredGraffitiFile(final BLSPublicKey publicKey, final String
   }
 
   @Test
-  void getGraffitiFromStorage_shouldGetGraffitiFromStorage(@TempDir final Path tempDir)
-      throws IOException {
+  void getGraffiti_shouldGetGraffitiFromStorage(@TempDir final Path tempDir) throws IOException {
     dataDirLayout = new SimpleDataDirLayout(tempDir);
     manager = new GraffitiManager(dataDirLayout);
     final Path filePath = getGraffitiManagementDir().resolve(getFileName(publicKey));
@@ -174,8 +173,15 @@ void getGraffitiFromStorage_shouldGetGraffitiFromStorage(@TempDir final Path tem
   }
 
   @Test
-  void getGraffitiFromStorage_shouldReturnEmptyWhenFileTooBig(@TempDir final Path tempDir)
-      throws IOException {
+  void getGraffiti_shouldReturnEmptyWhenFileNotExist(@TempDir final Path tempDir) {
+    dataDirLayout = new SimpleDataDirLayout(tempDir);
+    manager = new GraffitiManager(dataDirLayout);
+
+    assertThat(manager.getGraffiti(publicKey)).isEmpty();
+  }
+
+  @Test
+  void getGraffiti_shouldReturnEmptyWhenFileTooBig(@TempDir final Path tempDir) throws IOException {
     dataDirLayout = new SimpleDataDirLayout(tempDir);
     manager = new GraffitiManager(dataDirLayout);
 
@@ -188,7 +194,7 @@ void getGraffitiFromStorage_shouldReturnEmptyWhenFileTooBig(@TempDir final Path
 
   @Test
   @DisabledOnOs(OS.WINDOWS) // Can't set permissions on Windows
-  void getGraffitiFromStorage_shouldReturnEmptyWhenNotReadableFile(@TempDir final Path tempDir)
+  void getGraffiti_shouldReturnEmptyWhenNotReadableFile(@TempDir final Path tempDir)
       throws IOException {
     dataDirLayout = new SimpleDataDirLayout(tempDir);
     manager = new GraffitiManager(dataDirLayout);
@@ -200,8 +206,7 @@ void getGraffitiFromStorage_shouldReturnEmptyWhenNotReadableFile(@TempDir final
   }
 
   @Test
-  void getGraffitiFromStorage_shouldReturnEmptyWhenFileEmpty(@TempDir final Path tempDir)
-      throws IOException {
+  void getGraffiti_shouldReturnEmptyWhenFileEmpty(@TempDir final Path tempDir) throws IOException {
     dataDirLayout = new SimpleDataDirLayout(tempDir);
     manager = new GraffitiManager(dataDirLayout);
     final Path filePath = getGraffitiManagementDir().resolve(getFileName(publicKey));