Remove unnecessary exception catch after refactor

Author: courtneyeh

Diff for: validator/api/src/main/java/tech/pegasys/teku/validator/api/GraffitiManager.java

@@ -91,7 +91,7 @@ public Optional<Bytes32> getGraffitiFromStorage(final BLSPublicKey publicKey) {
     final Path filePath = graffitiPath.get().resolve(resolveFileName(publicKey));
     try {
       return Optional.of(GraffitiParser.loadFromFile(filePath)).filter(this::graffitiNotEmpty);
-    } catch (GraffitiLoaderException | IllegalArgumentException e) {
+    } catch (GraffitiLoaderException e) {
       LOG.error("Unable to read graffiti from storage.", e);
       return Optional.empty();
     }

Diff for: validator/api/src/test/java/tech/pegasys/teku/validator/api/GraffitiManagerTest.java

@@ -67,7 +67,6 @@ void setGraffiti_shouldSetGraffitiWhenFileNotExist(@TempDir final Path tempDir)
   void setGraffiti_shouldSetGraffitiWhenFileExist(@TempDir final Path tempDir) throws IOException {
     dataDirLayout = new SimpleDataDirLayout(tempDir);
     manager = new GraffitiManager(dataDirLayout);
-
     assertThat(getGraffitiManagementDir().resolve(getFileName(publicKey)).toFile().createNewFile())
         .isTrue();
 
@@ -81,6 +80,7 @@ void setGraffiti_shouldReturnErrorMessageWhenUnableToWriteFile(@TempDir final Pa
       throws IOException {
     dataDirLayout = new SimpleDataDirLayout(tempDir);
     manager = new GraffitiManager(dataDirLayout);
+    assertThat(getGraffitiManagementDir().toFile().exists()).isTrue();
 
     final File file = getGraffitiManagementDir().resolve(getFileName(publicKey)).toFile();
     assertThat(file.createNewFile()).isTrue();
@@ -108,7 +108,6 @@ void deleteGraffiti_shouldThrowExceptionWhenNoDirectory(@TempDir final Path temp
     assertThat(tempDir.toFile().setWritable(false)).isTrue();
     dataDirLayout = new SimpleDataDirLayout(tempDir);
     manager = new GraffitiManager(dataDirLayout);
-
     assertThat(getGraffitiManagementDir().toFile().exists()).isFalse();
     assertThat(manager.deleteGraffiti(dataStructureUtil.randomPublicKey()))
         .hasValue(GRAFFITI_DIR + " directory does not exist to handle update.");
@@ -119,7 +118,6 @@ void deleteGraffiti_shouldSetGraffitiWhenFileNotExist(@TempDir final Path tempDi
     dataDirLayout = new SimpleDataDirLayout(tempDir);
     manager = new GraffitiManager(dataDirLayout);
     assertThat(getGraffitiManagementDir().toFile().exists()).isTrue();
-
     assertThat(manager.deleteGraffiti(publicKey)).isEmpty();
     checkStoredGraffitiFile(publicKey, "");
   }
@@ -129,7 +127,6 @@ void deleteGraffiti_shouldSetGraffitiWhenFileExist(@TempDir final Path tempDir)
       throws IOException {
     dataDirLayout = new SimpleDataDirLayout(tempDir);
     manager = new GraffitiManager(dataDirLayout);
-
     assertThat(getGraffitiManagementDir().resolve(getFileName(publicKey)).toFile().createNewFile())
         .isTrue();
 
@@ -156,7 +153,6 @@ void shouldSetAndDeleteGraffitiWhenManagementPreexisting(@TempDir final Path tem
     dataDirLayout = new SimpleDataDirLayout(tempDir);
     final Path managementDir = getGraffitiManagementDir();
     assertThat(managementDir.toFile().mkdirs()).isTrue();
-
     manager = new GraffitiManager(dataDirLayout);
 
     assertThat(manager.setGraffiti(publicKey, graffiti)).isEmpty();