Skip to content

Commit 80687ba

Browse files
authored
Use correct end index for subList calls (Consensys#8271)
1 parent 8ddce8b commit 80687ba

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

ethereum/spec/src/main/java/tech/pegasys/teku/spec/logic/versions/electra/statetransition/epoch/EpochProcessorElectra.java

+4-8
Original file line numberDiff line numberDiff line change
@@ -165,8 +165,7 @@ public void processPendingBalanceDeposits(final MutableBeaconState state) {
165165

166166
final SszList<PendingBalanceDeposit> pendingBalanceDeposits =
167167
stateElectra.getPendingBalanceDeposits();
168-
for (int i = 0; i < pendingBalanceDeposits.size(); i++) {
169-
final PendingBalanceDeposit deposit = pendingBalanceDeposits.get(i);
168+
for (final PendingBalanceDeposit deposit : pendingBalanceDeposits) {
170169
if (processedAmount.plus(deposit.getAmount()).isGreaterThan(availableForProcessing)) {
171170
break;
172171
}
@@ -181,9 +180,7 @@ public void processPendingBalanceDeposits(final MutableBeaconState state) {
181180
stateElectra.setDepositBalanceToConsume(UInt64.ZERO);
182181
} else {
183182
final List<PendingBalanceDeposit> newList =
184-
pendingBalanceDeposits
185-
.asList()
186-
.subList(nextDepositIndex, pendingBalanceDeposits.size() - 1);
183+
pendingBalanceDeposits.asList().subList(nextDepositIndex, pendingBalanceDeposits.size());
187184
stateElectra.setPendingBalanceDeposits(
188185
schemaDefinitionsElectra.getPendingBalanceDepositsSchema().createFromElements(newList));
189186
stateElectra.setDepositBalanceToConsume(availableForProcessing.minusMinZero(processedAmount));
@@ -204,8 +201,7 @@ public void processPendingConsolidations(final MutableBeaconState state) {
204201
stateElectra.getPendingConsolidations();
205202
final UInt64 currentEpoch = stateAccessorsElectra.getCurrentEpoch(state);
206203

207-
for (int i = 0; i < pendingConsolidations.size(); i++) {
208-
final PendingConsolidation pendingConsolidation = pendingConsolidations.get(i);
204+
for (final PendingConsolidation pendingConsolidation : pendingConsolidations) {
209205
final Validator sourceValidator =
210206
state.getValidators().get(pendingConsolidation.getSourceIndex());
211207
if (sourceValidator.isSlashed()) {
@@ -234,7 +230,7 @@ public void processPendingConsolidations(final MutableBeaconState state) {
234230
final List<PendingConsolidation> newList =
235231
pendingConsolidations
236232
.asList()
237-
.subList(nextPendingBalanceConsolidation, pendingConsolidations.size() - 1);
233+
.subList(nextPendingBalanceConsolidation, pendingConsolidations.size());
238234
stateElectra.setPendingConsolidations(
239235
schemaDefinitionsElectra.getPendingConsolidationsSchema().createFromElements(newList));
240236
}

0 commit comments

Comments
 (0)