Skip to content

Commit 92996d3

Browse files
authored
add workflow include commit hash parameter (Consensys#8214)
* use pipeline level parameter instead of job parameter
1 parent 7547d87 commit 92996d3

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

.circleci/config.yml

+10-10
Original file line numberDiff line numberDiff line change
@@ -143,16 +143,12 @@ commands:
143143
144144
docker_publish_images:
145145
description: "Upload the docker images"
146-
parameters:
147-
include_commit_hash:
148-
type: boolean
149-
default: false
150146
steps:
151147
- run:
152148
name: "Publish Docker Images"
153149
command: |
154150
docker login --username "${DOCKER_USER_RW}" --password "${DOCKER_PASSWORD_RW}"
155-
./gradlew --no-daemon --parallel "-Pbranch=${CIRCLE_BRANCH} -PincludeCommitHash=<< parameters.include_commit_hash >>" uploadDocker
151+
./gradlew --no-daemon --parallel "-Pbranch=${CIRCLE_BRANCH} -PincludeCommitHash=<< pipeline.parameters.include_commit_hash >>" uploadDocker
156152
157153
notify:
158154
description: "Notify Slack"
@@ -161,6 +157,12 @@ commands:
161157
mentions: "team-centaur"
162158
fail_only: true
163159
only_for_branches: 'master'
160+
161+
parameters:
162+
include_commit_hash:
163+
type: boolean
164+
default: false
165+
164166
jobs:
165167
assemble:
166168
executor: large_executor
@@ -445,8 +447,7 @@ jobs:
445447
- attach_workspace:
446448
at: ~/project
447449
- docker_trust_sign
448-
- docker_publish_images:
449-
include_commit_hash: << parameters.include_commit_hash >>
450+
- docker_publish_images
450451
- notify
451452

452453
publishDockerArm64:
@@ -460,8 +461,7 @@ jobs:
460461
- attach_workspace:
461462
at: ~/project
462463
- docker_trust_sign
463-
- docker_publish_images:
464-
include_commit_hash: << parameters.include_commit_hash >>
464+
- docker_publish_images
465465
- notify
466466

467467
manifestDocker:
@@ -511,7 +511,7 @@ jobs:
511511
paths:
512512
- .openapidoc/spec/teku.json
513513

514-
# longish story here: we store the openapi json spec in the `gh-pages` branch of teku on Github
514+
# longish story here: we store the openapi json spec in the `gh-pages` branch of teku on Github
515515
# The reason we don't use GHA and instead use Circle to push to GHA is:
516516
# 1. We need assemble -> extractAPISpec -> publishAPISpec and this takes circa 10 mins to build in GHA,
517517
# 2. We publish artifacts (openapi, docker, binaries etc) only after ALL tests and we can't check for all the jobs passing to kick this one off

0 commit comments

Comments
 (0)