Skip to content

Fix FLAGS labeled DEPRECATED that are NOT DEPRECATED #170

Open
@afinetooth

Description

@afinetooth

Reported in:

To Do

  • Find out why these flags are marked deprecated when they are apparently not.
  • Remove DEPRECATION or DE-DUPLICATE FLAGS

DEPRECATED Flags

Here: https://github.com/coverallsapp/coverage-reporter/blob/63c62333bfb294e5de47362326e3c4ed9aa73c8b/src/coverage_reporter/cli/cmd.cr#L277C1-L350C10

      parser.on(
        "-bPATH",
        "--base-path=PATH",
        "DEPRECATED: Path to the root folder of the project the coverage was collected in"
      ) do |path|
        opts.base_path = path
      end

      parser.on("-fFILENAME", "--file=FILENAME", "DEPRECATED: Coverage artifact file to be reported, e.g. coverage/lcov.info (detected by default)") do |name|
        next if name.blank?

        opts.coverage_files = [name]
      end

      parser.on("-jFLAG", "--job-flag=FLAG", "DEPRECATED: Coverage job flag name, e.g. Unit Tests") do |flag|
        opts.job_flag_name = flag.presence
      end

      parser.on("-p", "--parallel", "DEPRECATED: Set the parallel flag. Requires webhook for completion (coveralls done)") do
        opts.parallel = true
      end

      parser.on("-d", "--done", "DEPRECATED: Call webhook after all parallel jobs (-p) done") do
        opts.parallel_done = true
      end

      parser.on("--format=FORMAT", "DEPRECATED: Force coverage file format, supported formats: #{Parser::PARSERS.map(&.name).join(", ")}") do |format|
        opts.format = format.presence
      end

      parser.on("--allow-empty", "DEPRECATED: Allow empty coverage results and exit 0") do
        opts.allow_empty = true
      end

      parser.on("--compare-ref=REF", "DEPRECATED: Git branch name to compare the coverage with") do |ref|
        opts.compare_ref = ref.presence
      end

      parser.on("--compare-sha=SHA", "DEPRECATED: Git commit SHA to compare the coverage with") do |sha|
        opts.compare_sha = sha.presence
      end

      parser.on("--carryforward=FLAGS", "DEPRECATED: Comma-separated list of parallel job flags") do |flags|
        opts.carryforward = flags
      end

      parser.on("--service-name=NAME", "DEPRECATED: Build service name override") do |service_name|
        opts.service_name = service_name.presence
      end

      parser.on("--service-job-id=ID", "DEPRECATED: Build job override") do |service_job_id|
        opts.service_job_id = service_job_id.presence
      end

      parser.on("--service-build-url=URL", "DEPRECATED: Build URL override") do |service_build_url|
        opts.service_build_url = service_build_url.presence
      end

      parser.on("--service-job-url=URL", "DEPRECATED: Build job URL override") do |service_job_url|
        opts.service_job_url = service_job_url.presence
      end

      parser.on("--service-branch=NAME", "DEPRECATED: Branch name override") do |service_branch|
        opts.service_branch = service_branch.presence
      end

      parser.on("--service-pull-request=NUMBER", "DEPRECATED: PR number override") do |service_pull_request|
        opts.service_pull_request = service_pull_request.presence
      end

      parser.on("-v", "--version", "DEPRECATED: Show version") do
        puts VERSION
        exit 0
      end

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions