Skip to content

Commit 7bbe2db

Browse files
committed
chore: review comments
1 parent 2545064 commit 7bbe2db

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

test/e2e/Deployment.t.sol

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@ interface IEIP173Proxy {
99
function owner() external view returns (address);
1010
}
1111

12+
// ref: https://github.com/wighawag/hardhat-deploy/blob/e0ffcf9e7dc92b246e832c4d175f9dbd8b6df14d/solc_0.8/proxy/EIP173Proxy.sol
13+
bytes32 constant EIP173_IMPLEMENTATION_SLOT = 0x360894a13ba1a3210667c828492db98dca3e2076cc3735a920a3ca505d382bbc;
14+
1215
contract DeploymentTest is Helper(false) {
1316
event Metadata(string, bytes);
1417

@@ -59,11 +62,11 @@ contract DeploymentTest is Helper(false) {
5962
);
6063
}
6164

62-
function test__authorization__authenticator_hash_dedicated_owner() external view {
65+
function test__authorization__authenticator_has_dedicated_owner() external view {
6366
assertEq(IEIP173Proxy(address(allowList)).owner(), owner, "owner not as expected");
6467
}
6568

66-
function test__authorization__authenticator_hash_dedicated_manager() external view {
69+
function test__authorization__authenticator_has_dedicated_manager() external view {
6770
assertEq(allowList.manager(), owner, "manager not as expected");
6871
}
6972

@@ -103,7 +106,7 @@ contract DeploymentTest is Helper(false) {
103106

104107
function _implementationAddress(address proxy) internal view returns (address) {
105108
return address(
106-
uint160(uint256(vm.load(proxy, 0x360894a13ba1a3210667c828492db98dca3e2076cc3735a920a3ca505d382bbc)))
109+
uint160(uint256(vm.load(proxy, EIP173_IMPLEMENTATION_SLOT)))
107110
);
108111
}
109112
}

0 commit comments

Comments
 (0)