Skip to content

Commit aad4f27

Browse files
committed
chore: address review comments
1 parent e09426b commit aad4f27

File tree

1 file changed

+4
-22
lines changed

1 file changed

+4
-22
lines changed

test/e2e/InternalBalances.t.sol

Lines changed: 4 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -30,35 +30,17 @@ contract InternalBalancesTest is Helper(false) {
3030
token1 = deployMintableErc20("TK1", "TK1");
3131
token2 = deployMintableErc20("TK2", "TK2");
3232

33-
GPv2Interaction.Data[] memory interactions = new GPv2Interaction.Data[](2);
34-
interactions[0] = GPv2Interaction.Data({
35-
target: address(token1),
36-
value: 0,
37-
callData: abi.encodeCall(IERC20.approve, (address(vault), type(uint256).max))
38-
});
39-
interactions[1] = GPv2Interaction.Data({
40-
target: address(token2),
41-
value: 0,
42-
callData: abi.encodeCall(IERC20.approve, (address(vault), type(uint256).max))
43-
});
44-
SettlementEncoder.EncodedSettlement memory encodedSettlement = encoder.encode(interactions);
45-
vm.prank(solver);
46-
settle(encodedSettlement);
33+
vm.startPrank(address(settlement));
34+
token1.approve(address(vault), type(uint256).max);
35+
token2.approve(address(vault), type(uint256).max);
36+
vm.stopPrank();
4737
}
4838

4939
function test_should_settle_orders_buying_and_selling_with_internal_balances() external {
5040
Vm.Wallet memory trader1 = vm.createWallet("trader1");
5141
Vm.Wallet memory trader2 = vm.createWallet("trader2");
5242
Vm.Wallet memory trader3 = vm.createWallet("trader3");
5343
Vm.Wallet memory trader4 = vm.createWallet("trader4");
54-
vm.label(trader1.addr, "trader1");
55-
vm.label(trader2.addr, "trader2");
56-
vm.label(trader3.addr, "trader3");
57-
vm.label(trader4.addr, "trader4");
58-
vm.label(address(token1), "token1");
59-
vm.label(address(token2), "token2");
60-
vm.label(vaultRelayer, "vaultRelayer");
61-
vm.label(address(vault), "vault");
6244

6345
// mint some tokens to trader1
6446
_mintTokens(token1, trader1.addr, 1.001 ether);

0 commit comments

Comments
 (0)