-
Notifications
You must be signed in to change notification settings - Fork 48
Open
Labels
E:5.2 Contracts migrationsSee https://github.com/cowprotocol/pm/issues/32 for detailsSee https://github.com/cowprotocol/pm/issues/32 for detailshelp wantedExtra attention is neededExtra attention is needed
Description
Description
There is a comprehensive test suite that needs to be migrated from hardhat to foundry.
External contributors
Upon completion of reference unit test and/or reference E2E test, external contributors are invited to contribute to the code base in the migration from hardhat to foundry for subsequent unit / E2E tests.
Work plan
- Assign yourself to a task (or external contributors, request assignment)
- In accordance with best practices, implement the nominated hardhat test suite in foundry.
- Code coverage must be equivalent.
- The submitted PR must have:
a. The foundry tests
b. Deleted the associated hardhat tests that were migrated
c. Runforge fmton the source code files that were added.
Tasks
- tests(core): test utilities #113
- tests(core): unit tests #114
- tests(core):
GPv2AllowListAuthenticator#115 - tests(core):
GPv2Interaction#116 - tests(core):
GPv2Order#117 - tests(core):
GPv2SafeERC20#118 - tests(core):
GPv2Settlement#119 - tests(core):
GPv2Signing#120 - tests(core):
GPv2Trade#121 - tests(core):
GPv2TradeSimulator#122 - tests(core):
GPv2Transfer#123 - tests(core):
GPv2VaultRelayer#124 - tests(core):
AllowListStorageReader#125 - tests(core):
decoding#126 - tests(core):
SettlementStorageReader#127 - tests(core):
sign#128
- tests(core):
- tests(core): e2e tests #130
- tests(e2e):
0xTrade#131 - tests(e2e):
zero-ex v2#132 - tests(e2e):
balancerSwap#133 - tests(e2e):
burnFees#134 - tests(e2e):
buyEth#135 - tests(e2e):
contractOrdersWithGnosisSafe#136 - tests(e2e):
internalBalances#137 - tests(e2e):
nonStandardERC20#138 - tests(e2e):
offchainAllowances#139 - tests(e2e):
simulateTrade#140 - tests(e2e):
uniswapTrade#141 - tests(e2e):
upgradeAuthenticator#142 - tests(e2e):
wineOilMarket#143
- tests(e2e):
- tests(core): reader tests #144
- tests(core): script tests #148
Metadata
Metadata
Assignees
Labels
E:5.2 Contracts migrationsSee https://github.com/cowprotocol/pm/issues/32 for detailsSee https://github.com/cowprotocol/pm/issues/32 for detailshelp wantedExtra attention is neededExtra attention is needed