Skip to content

Commit 228f3d7

Browse files
committed
fix: fix order signing
1 parent 3191677 commit 228f3d7

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@cowprotocol/cow-sdk",
3-
"version": "5.8.0-RC.4",
3+
"version": "5.8.0-RC.5",
44
"license": "(MIT OR Apache-2.0)",
55
"files": [
66
"/dist"

src/trading/getOrderTypedData.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,13 @@ import { ORDER_PRIMARY_TYPE, OrderTypedData } from './types'
33
import { OrderSigningUtils, UnsignedOrder } from '../order-signing'
44
import { SupportedChainId } from '../common'
55

6+
const EIP712DomainTypes = [
7+
{ name: 'name', type: 'string' },
8+
{ name: 'version', type: 'string' },
9+
{ name: 'chainId', type: 'uint256' },
10+
{ name: 'verifyingContract', type: 'address' },
11+
]
12+
613
export async function getOrderTypedData(
714
chainId: SupportedChainId,
815
orderToSign: UnsignedOrder
@@ -14,6 +21,7 @@ export async function getOrderTypedData(
1421
primaryType: ORDER_PRIMARY_TYPE,
1522
types: {
1623
[ORDER_PRIMARY_TYPE]: ORDER_TYPE_FIELDS,
24+
EIP712Domain: EIP712DomainTypes,
1725
},
1826
message: orderToSign,
1927
}

src/trading/types.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,7 @@ interface TypedDataField {
2525
export interface OrderTypedData {
2626
domain: TypedDataDomain
2727
primaryType: typeof ORDER_PRIMARY_TYPE
28-
types: {
29-
Order: TypedDataField[]
30-
}
28+
types: Record<string, TypedDataField[]>
3129
message: UnsignedOrder
3230
}
3331

0 commit comments

Comments
 (0)