Skip to content

Commit 3c57f55

Browse files
authored
chore: use a better name for main packages (#543)
* chore: use a better name for main packages * chore: undo change from #539 after it was fix in #540
1 parent 9e4a755 commit 3c57f55

File tree

3 files changed

+17
-15
lines changed

3 files changed

+17
-15
lines changed

.github/workflows/publish-github-packages.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -133,8 +133,7 @@ jobs:
133133
echo "is_pr=false" >> $GITHUB_OUTPUT
134134
fi
135135
136-
- name: Create pre-release versions for PRs
137-
if: steps.version.outputs.is_pr == 'true'
136+
- name: Create pre-release versions
138137
run: |
139138
# Create pre-release versions for all packages
140139
find packages -name "package.json" -exec sh -c '
@@ -163,8 +162,7 @@ jobs:
163162
env:
164163
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
165164

166-
- name: Restore original versions (PR only)
167-
if: steps.version.outputs.is_pr == 'true'
165+
- name: Restore original versions
168166
run: |
169167
# Restore original package.json versions
170168
git checkout -- packages/*/package.json

packages/bridging/src/BridgingSdk/strategies/BestQuoteStrategy.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ const adapters = createAdapters()
2424
const adapterNames = Object.keys(adapters) as Array<keyof typeof adapters>
2525

2626
adapterNames.forEach((adapterName) => {
27-
describe.skip(`BestQuoteStrategy with ${adapterName}`, () => {
27+
describe(`BestQuoteStrategy with ${adapterName}`, () => {
2828
let strategy: BestQuoteStrategyImpl
2929
let config: BridgingSdkConfig
3030
let tradingSdk: TradingSdk
@@ -122,7 +122,7 @@ adapterNames.forEach((adapterName) => {
122122
}
123123
})
124124

125-
describe.skip('execute', () => {
125+
describe('execute', () => {
126126
it('should return the best quote from all providers', async () => {
127127
const request = {
128128
quoteBridgeRequest,

packages/bridging/src/BridgingSdk/strategies/MultiQuoteStrategy.test.ts

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ const adapters = createAdapters()
2525
const adapterNames = Object.keys(adapters) as Array<keyof typeof adapters>
2626

2727
adapterNames.forEach((adapterName) => {
28-
describe.skip(`MultiQuoteStrategy with ${adapterName}`, () => {
28+
describe(`MultiQuoteStrategy with ${adapterName}`, () => {
2929
let strategy: MultiQuoteStrategyImpl
3030
let config: BridgingSdkConfig
3131
let tradingSdk: TradingSdk
@@ -254,19 +254,23 @@ adapterNames.forEach((adapterName) => {
254254

255255
mockProvider.getQuote = jest.fn().mockImplementation(async () => {
256256
provider1Called = true
257-
await new Promise((resolve) => setTimeout(() => {
258-
provider1Resolved = true
259-
resolve(bridgeQuoteResult)
260-
}, 100))
257+
await new Promise((resolve) =>
258+
setTimeout(() => {
259+
provider1Resolved = true
260+
resolve(bridgeQuoteResult)
261+
}, 100),
262+
)
261263
return bridgeQuoteResult
262264
})
263265

264266
mockProvider2.getQuote = jest.fn().mockImplementation(async () => {
265267
provider2Called = true
266-
await new Promise((resolve) => setTimeout(() => {
267-
provider2Resolved = true
268-
resolve(bridgeQuoteResult)
269-
}, 100))
268+
await new Promise((resolve) =>
269+
setTimeout(() => {
270+
provider2Resolved = true
271+
resolve(bridgeQuoteResult)
272+
}, 100),
273+
)
270274
return bridgeQuoteResult
271275
})
272276

0 commit comments

Comments
 (0)