Skip to content

Conversation

@shoom3301
Copy link
Contributor

No description provided.

…AIN_TO_NATIVE_WRAPPED_TOKEN_ADDRESS to support wrapped assets, changes an import and rm the sending of native tokens within getUnsignedBridgeCall
…ithin getSignedHook and implements getBridgingParams
…ment and a remove a useless check within getBridgingParams
…ithin getSignedHook, fixes getTokenByAddressAndChainId and getIntermediateTokens
…ridgeCallWithoutHooks within NearIntentsBridgeProvider
…m getUnsignedBridgeCall in favour of the balance of the sell token within the cowshed account at the swap time
…irect transfer to near deposit address within NearIntentsBridgeProvider
…col/one-click-sdk-typescript within dependencies
…TS_BLOCKCHAIN_TO_NATIVE_WRAPPED_TOKEN_ADDRESS into WRAPPED_NATIVE_CURRENCIES
carlos-cow and others added 23 commits November 3, 2025 23:27
* fix: flashloan fee calculation now matches aave's

* fix: pr comments

* fix: implement ceil rounding for flash loan fee calculations (#623)

- Fixed calculateFlashLoanAmounts to use ceil rounding (round up on any remainder)
- This ensures flash loan fees are never undercharged due to truncation
- Removed incorrect 100x scaling that was using BASIS_POINTS_SCALE
- Now using Aave's PERCENT_SCALE (10000) directly where 100% = 10000 bps
- Added 7 comprehensive unit tests covering edge cases:
  - Very small amounts (1 wei)
  - Exact division with no remainder
  - Small remainders
  - Medium DeFi amounts (ETH scale)
  - Large amounts (100+ ETH)
  - Maximum uint256-like amounts
  - Fractional percentages with remainders
- All 99 tests passing

* add opt-out flag for quote adjustments in getOrderToSign (#624)

* feat: add opt-out flag for quote adjustments in getOrderToSign

* override order to sign from params (#626)

* use applyQuote boolean instead of overriding orderToSign (#628)

* fix: pr review

---------

Co-authored-by: Martin Grabina <[email protected]>

* fix: lint

* fix: more pipeline fixes

---------

Co-authored-by: Martin Grabina <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…bstance-labs-feat/near-intents

# Conflicts:
#	.release-please-manifest.json
#	packages/flash-loans/CHANGELOG.md
#	packages/flash-loans/package.json
…ents-fixes

fix: fix bridging providerId detection
…ents-fixes

feat(bridging): use multiple providers for tokens and networks
…bstance-labs-feat/near-intents-2

# Conflicts:
#	packages/contracts-ts/src/generated/packageVersion.ts
@shoom3301 shoom3301 marked this pull request as draft November 7, 2025 12:10
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 7, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch substance-labs-feat/near-intents-3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

📦 GitHub Packages Published

Last updated: Nov 7, 2025, 12:17:19 PM UTC

The following packages have been published to GitHub Packages with pre-release version pr-659-693a2cdb:


Installation

These packages require authentication to install from GitHub Packages. First, create a .npmrc file:

# Create .npmrc file in your project root
echo "@cowprotocol:registry=https://npm.pkg.github.com" > .npmrc
echo "//npm.pkg.github.com/:_authToken=YOUR_GITHUB_TOKEN" >> .npmrc

To get your GitHub token:

  1. Go to https://github.com/settings/tokens
  2. Click "Generate new token (classic)"
  3. Check only the "read:packages" scope
  4. Copy the token and replace YOUR_GITHUB_TOKEN in the .npmrc file

Then install any of the packages above, either by exact version (i.e. @cowprotocol/[email protected]) or more conveniently by using the tag (@cowprotocol/cow-sdk@pr-659):

# Yarn
yarn add npm:@cowprotocol/cow-sdk@pr-659

# pnpm
pnpm install npm:@cowprotocol/cow-sdk@pr-659

# NPM
npm install npm:@cowprotocol/cow-sdk@pr-659

Update to the latest version (only if you used the tag)

Every commit will publish a new package. To upgrade to the latest version, run:

# Yarn
yarn upgrade @cowprotocol/cow-sdk

# pnpm
pnpm update @cowprotocol/cow-sdk

# NPM
npm update @cowprotocol/cow-sdk

View Packages

You can view the published packages at: https://github.com/cowprotocol/cow-sdk/packages

@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​defuse-protocol/​one-click-sdk-typescript@​0.1.1-0.2771009994100
Updated@​wagmi/​cli@​2.5.1 ⏵ 2.7.197 +110078 +397 +1100
Updated@​types/​react@​18.3.24 ⏵ 18.3.2610010079 +195 +1100

View full report

@shoom3301 shoom3301 closed this Nov 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants