Merge pull request #6075 from cowprotocol/fix/cow-fi

fix(cow-fi): update articles page with caching strategy and type annotations

Author: alfetopito

apps/cow-fi/app/(learn)/learn/[article]/page.tsx

@@ -17,7 +17,9 @@ import {
 
 import type { Metadata } from 'next'
 
-export const revalidate = 3600 // Revalidate at most once per hour
+// Next.js requires revalidate to be a literal number for static analysis
+// This value (3600 seconds = 1 hour) should match CMS_CACHE_TIME in services/cms/index.ts
+export const revalidate = 3600
 
 // Maximum length for metadata descriptions. When content exceeds MAX_LENGTH,
 // we truncate to TRUNCATE_LENGTH (MAX_LENGTH - 3) to make room for "..." ellipsis

apps/cow-fi/app/(learn)/learn/articles/[[...pageIndex]]/page.tsx

@@ -1,6 +1,8 @@
-import { ArticlesPageComponents } from '@/components/ArticlesPageComponents'
 import { redirect } from 'next/navigation'
-import { Article, getArticles, getCategories } from '../../../../../services/cms'
+
+import { Article, Category, getArticles, getCategories } from '../../../../../services/cms'
+
+import { ArticlesPageComponents } from '@/components/ArticlesPageComponents'
 import { ARTICLES_PER_PAGE } from '@/const/pagination'
 import { calculateTotalPages } from '@/util/paginationUtils'
 
@@ -17,6 +19,8 @@ export type ArticlesResponse = {
   }
 }
 
+// TODO: Add proper return type annotation
+// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export async function generateStaticParams() {
   const articlesResponse = await getArticles({ page: 0, pageSize: ARTICLES_PER_PAGE })
   const totalArticles = articlesResponse.meta?.pagination?.total || 0
@@ -25,6 +29,13 @@ export async function generateStaticParams() {
   return Array.from({ length: totalPages }, (_, i) => ({ pageIndex: [(i + 1).toString()] }))
 }
 
+// Next.js requires revalidate to be a literal number for static analysis
+// This value (3600 seconds = 1 hour) should match CMS_CACHE_TIME in services/cms/index.ts
+export const revalidate = 3600
+
+// TODO: Reduce function complexity by extracting logic
+// TODO: Add proper return type annotation
+// eslint-disable-next-line complexity, @typescript-eslint/explicit-function-return-type
 export default async function Page({ params }: Props) {
   const pageParam = (await params)?.pageIndex?.[0]
   const paramsAreSet = Boolean(pageParam)
@@ -52,6 +63,8 @@ export default async function Page({ params }: Props) {
   const allArticles = allArticlesResponse.data
 
   const articles =
+    // TODO: Reduce function complexity by extracting logic
+    // eslint-disable-next-line complexity
     articlesResponse.data?.map((article: Article) => ({
       ...article,
       id: article.id || 0,
@@ -69,7 +82,7 @@ export default async function Page({ params }: Props) {
 
   const categoriesResponse = await getCategories()
   const allCategories =
-    categoriesResponse?.map((category: any) => ({
+    categoriesResponse?.map((category: Category) => ({
       name: category?.attributes?.name || '',
       slug: category?.attributes?.slug || '',
     })) || []

apps/cow-fi/next.config.ts

@@ -3,7 +3,6 @@ import { WithNxOptions } from '@nx/next/plugins/with-nx'
 
 const nextConfig: WithNxOptions = {
   reactStrictMode: true,
-  swcMinify: true,
   nx: {
     svgr: false,
   },
@@ -87,10 +86,7 @@ const nextConfig: WithNxOptions = {
       },
     ]
   },
-  i18n: {
-    locales: ['en'],
-    defaultLocale: 'en',
-  },
+
   images: {
     domains: ['celebrated-gift-f83e5c9419.media.strapiapp.com'],
     remotePatterns: [
@@ -102,13 +98,22 @@ const nextConfig: WithNxOptions = {
   },
   async headers() {
     return [
-      // Cache all pages for 60 seconds
+      {
+        source: '/learn/:path*',
+        headers: [
+          {
+            key: 'Cache-Control',
+            value: 'public, s-maxage=3600, stale-while-revalidate=86400', // 1h cache, 24h stale
+          },
+        ],
+      },
+      // Cache all other pages for 1 hour
       {
         source: '/:path*',
         headers: [
           {
             key: 'Cache-Control',
-            value: 'public, s-maxage=60, stale-while-revalidate=300',
+            value: 'public, s-maxage=3600, stale-while-revalidate=86400', // 1h cache, 24h stale
           },
         ],
       },