Skip to content

Conversation

@crutch12
Copy link
Contributor

@crutch12 crutch12 commented Dec 3, 2025

Summary

Fixes #6601

image image

To Test

  1. Check cowswap dropdown menu
  2. Check cow.fi dropdown menu

Summary by CodeRabbit

  • Bug Fixes
    • Fixed positioning of menu item dividers to display correctly.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link

vercel bot commented Dec 3, 2025

@crutch12 is attempting to deploy a commit to the cow Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 3, 2025

Walkthrough

A single CSS styling fix restores the position: relative property to the .hasDivider style in StyledDropdownContentItem, enabling proper rendering of dropdown menu item dividers in the MenuBar component.

Changes

Cohort / File(s) Summary
CSS Positioning Fix
libs/ui/src/pure/MenuBar/styled.ts
Added position: relative to .hasDivider style to enable correct ::after pseudo-element positioning for dropdown menu item dividers

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

Design

Suggested reviewers

  • shoom3301

Poem

🐰✨ A divider lost in rebranding's sea,
Now position: relative sets it free!
The dropdown blooms with lines so fine,
Between each item, a perfect design. 🍕

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description includes issue reference and before/after screenshots, but lacks detailed testing steps with checkboxes and background context as specified in the template. Expand 'To Test' section with numbered steps and checkbox-style verification items as shown in the template, and optionally add background information.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: fixing the lost divider for the first menu element.
Linked Issues check ✅ Passed The code change directly addresses the core requirement from issue #6601 by restoring 'position: relative' to fix the divider visibility.
Out of Scope Changes check ✅ Passed The single file change is narrowly scoped to fixing the divider visibility issue and contains no unrelated modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ce4d7e3 and b79eecd.

📒 Files selected for processing (1)
  • libs/ui/src/pure/MenuBar/styled.ts (1 hunks)
🔇 Additional comments (1)
libs/ui/src/pure/MenuBar/styled.ts (1)

453-453: LGTM! Correct fix for the missing divider.

Adding position: relative establishes the positioning context required for the ::after pseudo-element (line 457) to render the divider correctly. Without this, the absolutely positioned pseudo-element would anchor to the nearest positioned ancestor, causing the divider to be misplaced or invisible.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel
Copy link

vercel bot commented Dec 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
swap-dev Ready Ready Preview Dec 3, 2025 10:44am

Copy link
Contributor

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@shoom3301 shoom3301 merged commit 88ab93e into cowprotocol:develop Dec 4, 2025
9 of 15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MenuBar: DropdownMenu first item has no visible divider

3 participants