fix(permit): nonce not supported #5653 #5672

alfetopito · 2025-05-07T16:18:15Z

Summary

Fixes #5653

Permits should work again for AAVE and like tokens

To Test

See test instructions in the linked issue

Permits should continue working for other tokens other than AAVE, like DAI, USDC, etc.

Summary by CodeRabbit

Bug Fixes
- Improved error handling when retrieving nonce values, allowing alternative methods to be tried if an invalid nonce is encountered.
Chores
- Updated package version to 0.6.1-RC.0.
Style
- Minor formatting adjustments for improved code readability.

vercel · 2025-05-07T16:18:19Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
cowfi	✅ Ready (Inspect)	Visit Preview	May 7, 2025 4:56pm
explorer-dev	✅ Ready (Inspect)	Visit Preview	May 7, 2025 4:56pm
swap-dev	✅ Ready (Inspect)	Visit Preview	May 7, 2025 4:56pm

3 Skipped Deployments

Name	Status	Preview	Updated (UTC)
cosmos	⬜️ Ignored (Inspect)	Visit Preview	May 7, 2025 4:56pm
sdk-tools	⬜️ Ignored (Inspect)	Visit Preview	May 7, 2025 4:56pm
widget-configurator	⬜️ Ignored (Inspect)	Visit Preview	May 7, 2025 4:56pm

coderabbitai · 2025-05-07T16:18:22Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes update the version of the @cowprotocol/permit-utils package, adjust object formatting in the estimateTokenPermit function, and modify the nonce error handling logic in the 1inch permit utility patch to attempt alternative nonce retrieval methods instead of failing immediately when an invalid nonce is encountered.

Changes

File(s)	Change Summary
libs/permit-utils/package.json	Updated version from `0.6.0` to `0.6.1-RC.0`.
libs/permit-utils/src/lib/getTokenPermitInfo.ts	Reformatted the returned object in `estimateTokenPermit` for improved indentation, with no logic changes.
patches/@1inch+permit-signed-approvals-utils+1.4.10.patch	Modified nonce retrieval logic: now recursively tries alternative methods if nonce is invalid, instead of error.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Eip2612PermitUtils
    participant EthereumNode

    User->>Eip2612PermitUtils: Request permit signature
    loop Fetch nonce
        Eip2612PermitUtils->>EthereumNode: Get nonce (method index N)
        EthereumNode-->>Eip2612PermitUtils: Return nonce
        alt Nonce is '0x' or NaN
            Eip2612PermitUtils->>Eip2612PermitUtils: Try next method index (N+1)
        else Valid nonce
            Eip2612PermitUtils-->>User: Return permit signature
        end
    end

Assessment against linked issues

Objective	Addressed	Explanation
Prevent "Nonce is NAN" error by attempting alternative nonce retrieval methods (#5653)	✅
Ensure permit signing is possible for tokens previously causing "Nonce not supported" errors (#5653)	✅

Poem

In the warren, nonce errors once did abound,
But now, with a hop, a solution is found!
If a nonce is amiss, don’t despair or frown—
The code tries again, it won’t let you down.
With a version hop too, this patch is complete,
The rabbits rejoice—permit flows are sweet!
🐇✨

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

alfetopito · 2025-05-07T16:18:41Z

@coderabbitai review

coderabbitai · 2025-05-07T16:18:47Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

… non-failure

apps/cowswap-frontend/src/modules/permit/hooks/usePreGeneratedPermitInfo.ts

shoom3301 · 2025-05-08T06:34:16Z

patches/@1inch+permit-signed-approvals-utils+1.4.10.patch

+             .catch(() => this.getTokenNonceByMethod(tokenAddress, walletAddress, nonceMethodNameIndex + 1))
+             .then((res) => {
+             if (res === '0x' || Number.isNaN(Number(res))) {
+-                return Promise.reject(new Error('nonce is NaN'));


In which cases res is not a valid number? Some specific tokens?

That I don't know.
In the AAVE case specifically, it's returning 0x instead of throwing, which is a problem because it doesn't check the other nonce methods.
To be honest, I don't know why it started to not throw either, as I assume before it did given that we were able to call the right method in the past.
OR the AAVE token implementation changed 🤷

elena-zh · 2025-05-08T09:47:31Z

Hey @alfetopito , I don't see 'gas-fee' labels in token lists in this PR:

Reproducible on any chain

The label appears when I sign a permit only for a token

alfetopito · 2025-05-08T09:58:37Z

Hey @alfetopito , I don't see 'gas-fee' labels in token lists in this PR:

Reproducible on any chain

The label appears when I sign a permit only for a token

That's expected.
It uses the pre-generated permit. Since I disabled it for this PR, it'll only show up after you pick a token as sell.

elena-zh · 2025-05-08T10:44:39Z

Changes LGTM then!
I've been able to sign and trade aave, 1inch and other permittable tokens on different chains.
Also, the flow has not been modified for SC wallets.
And now DAI token is not permittable on Ethereum.

alfetopito · 2025-05-08T11:05:26Z

Changes LGTM then! I've been able to sign and trade aave, 1inch and other permittable tokens on different chains. Also, the flow has not been modified for SC wallets. And now DAI token is not permittable on Ethereum.

Great!

I have reverted the change to make use of the pre-generated permit again.
Can you check whether the initial failure case is reproducible?

Also, I think DAI should work again 🤞

I'd like to check the DAI issue in another task to not block this fix.

elena-zh · 2025-05-08T13:12:32Z

Dai is still not recognized as a permittable token

All the rest changes LGTM!

elena-zh

Approving since you will investigate DAI issue in a separate task

alfetopito self-assigned this May 7, 2025

alfetopito changed the title ~~Fix/5653 nonce not supported~~ fix(permit): nonce not supported #5653 May 7, 2025

alfetopito added 3 commits May 7, 2025 17:24

fix: patch 1inch lib to keep trying other nonce methods when we get a…

d4af90c

… non-failure

chore: pointless change just to trigger lib release

499afe7

chore: bump pkg version to 0.6.1-RC.0

79bbbe2

alfetopito force-pushed the fix/5653_nonce-not-supported branch from 7d69a6a to 79bbbe2 Compare May 7, 2025 16:24

vercel bot deployed to Preview – cowfi May 7, 2025 16:31 View deployment

vercel bot deployed to Preview – explorer-dev May 7, 2025 16:32 View deployment

vercel bot deployed to Preview – swap-dev May 7, 2025 16:38 View deployment

alfetopito commented May 7, 2025

View reviewed changes

apps/cowswap-frontend/src/modules/permit/hooks/usePreGeneratedPermitInfo.ts Outdated Show resolved Hide resolved

alfetopito added the RELEASE Included in the release that is being closed label May 7, 2025

vercel bot deployed to Preview – explorer-dev May 7, 2025 16:53 View deployment

vercel bot deployed to Preview – swap-dev May 7, 2025 16:56 View deployment

vercel bot deployed to Preview – cowfi May 7, 2025 16:56 View deployment

shoom3301 reviewed May 8, 2025

View reviewed changes

alfetopito force-pushed the fix/5653_nonce-not-supported branch from bb1b5c1 to 79bbbe2 Compare May 8, 2025 10:54

alfetopito marked this pull request as ready for review May 8, 2025 11:05

alfetopito requested review from a team May 8, 2025 11:05

shoom3301 approved these changes May 8, 2025

View reviewed changes

elena-zh approved these changes May 8, 2025

View reviewed changes

alfetopito merged commit a526222 into main May 8, 2025
19 of 21 checks passed

alfetopito deleted the fix/5653_nonce-not-supported branch May 8, 2025 14:11

github-actions bot locked and limited conversation to collaborators May 8, 2025

fix(permit): nonce not supported #5653 #5672

fix(permit): nonce not supported #5653 #5672

Uh oh!

Conversation

alfetopito commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

To Test

Summary by CodeRabbit

Uh oh!

vercel bot commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Sequence Diagram(s)

Assessment against linked issues

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

alfetopito commented May 7, 2025

Uh oh!

coderabbitai bot commented May 7, 2025

Uh oh!

Uh oh!

shoom3301 May 8, 2025

Choose a reason for hiding this comment

Uh oh!

alfetopito May 8, 2025

Choose a reason for hiding this comment

Uh oh!

elena-zh commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alfetopito commented May 8, 2025

Uh oh!

elena-zh commented May 8, 2025

Uh oh!

alfetopito commented May 8, 2025

Uh oh!

elena-zh commented May 8, 2025

Uh oh!

elena-zh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alfetopito commented May 7, 2025 •

edited

Loading

vercel bot commented May 7, 2025 •

edited

Loading

coderabbitai bot commented May 7, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

elena-zh commented May 8, 2025 •

edited

Loading