-
Notifications
You must be signed in to change notification settings - Fork 149
feat: enhance token selector modal #6500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… for improved token selection
…logic and improving structure
…n package.json and yarn.lock
…SelectionHandler type
…ased on trade type
…in token selection
…nd active chain label
Summary
@tanstack/react-virtualto 3.13.12, tweaked trade-widget sizing when the sidebar is open, and polished shared UI elements like the search input placeholder behavior.TokenSelectionHandler, keep the selector open-state consistent with issue Token selector is not closed when pick a token from another network #6251, and ensure SELL-side Limit/TWAP selections await wallet chain switches while still closing the modal afterward.useChainsToSelectinto documented helpers (createSingleChainState,createInputChainsState,createOutputChainsState) so the sell-vs-bridge logic stays explicit and lint-friendly without changing behavior.To Test
Select Token Modal — Desktop
Select Token Modal — Mobile
Token List Content
Token Search Results
currency-importon the first blockchain match) and auto-select when only one match exists.LP Token Lists
Trade Widget Width
tokenSelectSidebarmax width, otherwise the standard token-select width.Theme / UI Regression
@tanstack/[email protected]upgrade.Token Selection Behavior
onSelectTokenwithout double-closing or re-opening the modal.Chain Availability Logic
Background
@tanstack/react-virtualupgrade and the newscrollResetKeyprop, which is reused by search results and the main token list.