Skip to content

Conversation

@fairlighteth
Copy link
Contributor

@fairlighteth fairlighteth commented Nov 13, 2025

Summary

This PR kicks off the token selector split by landing the shared UI primitives: chain accent CSS vars, the wider sidebar width token, polished SearchInput focus behavior, a more flexible VirtualList (loading placeholders + scroll reset), a refactored TokenLogo (separate LP vs standard paths with reusable hooks), and lazy‑mounted Popover portals.

To Test

  1. Virtual list + popover sanity

    • Open the token selector and scroll a long list; it should render smoothly and jump back to the top when switching chains/search context.
    • While hovering items with tooltips, confirm hidden popovers no longer cause long initial pauses.
  2. Token logos

    • LP tokens still render dual logos, while standard tokens show the correct letter/placeholder if no image exists.
    • Network badges appear only when enabled and remain aligned after the refactor.
  3. Search inputs

    • The placeholder text fades out on focus and reappears once unfocused without visual glitches.

Background

Part 1 of 9, establishing the base styling/building blocks so subsequent PRs can focus on behavioral changes without reworking shared components.

@fairlighteth fairlighteth self-assigned this Nov 13, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 13, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/token-selector-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel
Copy link

vercel bot commented Nov 13, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
cowfi Ready Ready Preview Nov 13, 2025 6:21pm
explorer-dev Ready Ready Preview Nov 13, 2025 6:21pm
sdk-tools Ready Ready Preview Nov 13, 2025 6:21pm
swap-dev Ready Ready Preview Nov 13, 2025 6:21pm
widget-configurator Ready Ready Preview Nov 13, 2025 6:21pm
1 Skipped Deployment
Project Deployment Preview Updated (UTC)
cosmos Ignored Ignored Nov 13, 2025 6:21pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants