Skip to content

Conversation

@fairlighteth
Copy link
Contributor

Summary

This PR delivers the token-row performance foundations from the split plan: a shared useDeferredVisibility hook plus deferred rendering for token tags/address and balance/fiat formatting so the selector only hydrates rows that are near the viewport.

To Test

  1. Token selector scrolling

    • Open the token selector on a long network and scroll top-to-bottom; rows should populate smoothly without the earlier jank.
    • Scroll quickly—tags and addresses should appear just before the row enters view, never staying blank once visible.
    • Watch the balance column: a loading shimmer should show off-screen, then switch to formatted balances/fiat once visible.
  2. Wallet disconnected

    • Disconnect the wallet and confirm the balance column remains hidden (same as before).
  3. Re-filtering

    • Switch chains or update the search query; previously rendered rows should reset their deferred state and only hydrate again after they re-enter the viewport.

Background

Part of the staged token-selector rollout, focusing on deferring expensive row work (logos, tags, fiat) until necessary.

@vercel
Copy link

vercel bot commented Nov 13, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
cowfi Ready Ready Preview Nov 13, 2025 7:35pm
explorer-dev Ready Ready Preview Nov 13, 2025 7:35pm
sdk-tools Ready Ready Preview Nov 13, 2025 7:35pm
swap-dev Ready Ready Preview Nov 13, 2025 7:35pm
widget-configurator Ready Ready Preview Nov 13, 2025 7:35pm
1 Skipped Deployment
Project Deployment Preview Updated (UTC)
cosmos Ignored Ignored Nov 13, 2025 7:35pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 13, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/token-selector-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants